From 9a235933b78cd774bd08ba2d576f6ae91b23502d Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sun, 17 Jul 2022 15:18:32 -0700 Subject: [PATCH] gvc: remove unused 'gvevent_delete' The `del` field was added to `gvdevice_callbacks_t` in ad82f9fa3212cbaa01625f3c27a1e90c1c990fd2 under the name `delete`, but seemingly has never been used by any in-tree plugin. This commit removes a no-op, never-called callback for it, squashing some -Wunused-parameter warnings. This commit does not remove the member because it is part of the public API. We are assuming the convention is to check these pointers against null before calling them, like the other GVC structs. But the struct has no comment explaining it nor how it is meant to be used, so we cannot be sure how/if users would be relying on this. --- lib/gvc/gvevent.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/gvc/gvevent.c b/lib/gvc/gvevent.c index 8cbaf4ec5..61236c458 100644 --- a/lib/gvc/gvevent.c +++ b/lib/gvc/gvevent.c @@ -545,11 +545,6 @@ static int toggle_fit_cb(GVJ_t * job) return 0; } -static void gvevent_delete (GVJ_t * job) -{ - /* FIXME */ -} - static void gvevent_read (GVJ_t * job, const char *filename, const char *layout) { FILE *f; @@ -649,7 +644,7 @@ gvdevice_callbacks_t gvdevice_callbacks = { gvevent_button_release, gvevent_motion, NULL, // modify - gvevent_delete, + NULL, // del gvevent_read, gvevent_layout, gvevent_render, -- 2.40.0