From 998ebf4ce6bc7d512b1c172a5ba286c616abcb11 Mon Sep 17 00:00:00 2001 From: garima-g Date: Thu, 5 Nov 2015 11:16:34 +0530 Subject: [PATCH] Add self-assignment check in operator= Method 'operator=' should check its argument with 'this' pointer. --- taglib/mp4/mp4coverart.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/taglib/mp4/mp4coverart.cpp b/taglib/mp4/mp4coverart.cpp index 2746469d..f2152335 100644 --- a/taglib/mp4/mp4coverart.cpp +++ b/taglib/mp4/mp4coverart.cpp @@ -54,11 +54,12 @@ MP4::CoverArt::CoverArt(const CoverArt &item) : d(item.d) MP4::CoverArt & MP4::CoverArt::operator=(const CoverArt &item) { - if(d->deref()) { - delete d; + if(&item != this) { + if(d->deref()) + delete d; + d = item.d; + d->ref(); } - d = item.d; - d->ref(); return *this; } -- 2.40.0