From 996fa80c175db9db49c81cf78e8e292101ce1e3e Mon Sep 17 00:00:00 2001
From: Jordan Rose <jordan_rose@apple.com>
Date: Thu, 5 Jul 2012 18:48:30 +0000
Subject: [PATCH] Release notes for r158230 "Disallow using ObjC literals in
 direct comparisons"

This may turn out to be a controversial change, due to string literals being
uniqued at link time, but Apple's docs only say "The compiler makes such
object constants unique on a per-module basis..."[1] without actually saying
what a "module" is. (It's not a clang module.) Furthermore, this uniqueness
guarantee often can't be guaranteed once the string has been passed through
framework code.

If this does turn out very controversial, we could downgrade this to a
DefaultError warning for strings, and leave it as a true Error for other
kinds of literals.

(<rdar://problem/11300873>)

[1]: https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/Strings/Articles/CreatingStrings.html

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@159766 91177308-0d34-0410-b5e6-96231b3b80d8
---
 docs/ReleaseNotes.html | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/docs/ReleaseNotes.html b/docs/ReleaseNotes.html
index b820e8dc3f..6c38c712e7 100644
--- a/docs/ReleaseNotes.html
+++ b/docs/ReleaseNotes.html
@@ -218,7 +218,21 @@ model can be used.
 <h3 id="objcchanges">Objective-C Language Changes in Clang</h3>
 <!-- = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = -->
 
-<p>...</p>
+<ul>
+  <li>
+    <p>It is now an error to compare against the addresses of Objective-C
+       literals. This is usually a simple mistake (using <code>==</code> instead
+       of <code>-isEqual:</code>), and the result depends on the implementation
+       of the various literals, none of which are guaranteed to be uniqued or
+       always newly-allocated.</p>
+    <p>In the past, we allowed comparisons against literal strings
+       (<code>@"..."</code>), since they are currently uniqued across
+       translation units at link time. This is an implementation detail and
+       should not be relied upon. If you are using such code, please use global
+       string constants instead (<code>NSString * const MyConst = @"..."</code>)
+       or use <code>-isEqual:</code>.</p>
+  </li>
+</ul>
 
 <!-- = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = -->
 <h3 id="apichanges">Internal API Changes</h3>
-- 
2.40.0