From 992b42a1fe0c0791ea690db7057439400d0910e7 Mon Sep 17 00:00:00 2001 From: Eric Covener Date: Thu, 29 Dec 2016 18:27:12 +0000 Subject: [PATCH] mod_remoteip: Set useragent port to zero PR59931 When overriding the useragent address from X-Forwarded-For, zero out what had been initialized as the connection-level port. Submitted By: Hank Ibell git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1776458 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES | 4 ++++ modules/metadata/mod_remoteip.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/CHANGES b/CHANGES index 52f02efe33..1de27cba17 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,10 @@ -*- coding: utf-8 -*- Changes with Apache 2.5.0 + *) mod_remoteip: When overriding the useragent address from X-Forwarded-For, + zero out what had been initialized as the connection-level port. PR59931. + [Hank Ibell ] + *) mod_proxy_wstunnel: Reliably run before mod_proxy_http. [Eric Covener] diff --git a/modules/metadata/mod_remoteip.c b/modules/metadata/mod_remoteip.c index 28e01df297..06fc3f483b 100644 --- a/modules/metadata/mod_remoteip.c +++ b/modules/metadata/mod_remoteip.c @@ -394,6 +394,9 @@ static int remoteip_modify_request(request_rec *r) return OK; } + /* Port is not known so set it to zero; otherwise it can be misleading */ + req->useragent_addr->port = 0; + req->proxied_remote = remote; req->proxy_ips = proxy_ips; -- 2.50.1