From 987d44f3269728589090508be68936694567331e Mon Sep 17 00:00:00 2001 From: Huihui Zhang Date: Thu, 27 Jun 2019 05:46:06 +0000 Subject: [PATCH] [InstCombine][NFCI] Fix test comments. For fold (X & (signbit l>> Y)) ==/!= 0 -> (X << Y) >=/< 0 (X & (signbit << Y)) ==/!= 0 -> (X l>> Y) >=/< 0 Test cases of X being constant are positive tests not negative. Prep work for D62818. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@364497 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll | 4 ++-- test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll b/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll index c80294941e1..72c21329708 100644 --- a/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll +++ b/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll @@ -183,8 +183,6 @@ define i1 @scalar_i32_signbit_lshr_and_eq_extra_use_lshr_and(i32 %x, i32 %y, i32 ret i1 %r } -; Negative tests - ; X is constant define i1 @scalar_i32_signbit_lshr_and_eq_X_is_constant1(i32 %y) { @@ -211,6 +209,8 @@ define i1 @scalar_i32_signbit_lshr_and_eq_X_is_constant2(i32 %y) { ret i1 %r } +; Negative tests + ; Check 'slt' predicate define i1 @scalar_i32_signbit_lshr_and_slt(i32 %x, i32 %y) { diff --git a/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll b/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll index 12c06cb49a1..674d0c28d01 100644 --- a/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll +++ b/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll @@ -183,8 +183,6 @@ define i1 @scalar_i32_signbit_shl_and_eq_extra_use_shl_and(i32 %x, i32 %y, i32 % ret i1 %r } -; Negative tests - ; X is constant define i1 @scalar_i32_signbit_shl_and_eq_X_is_constant1(i32 %y) { @@ -213,6 +211,8 @@ define i1 @scalar_i32_signbit_shl_and_eq_X_is_constant2(i32 %y) { ret i1 %r } +; Negative tests + ; Check 'slt' predicate define i1 @scalar_i32_signbit_shl_and_slt(i32 %x, i32 %y) { -- 2.50.1