From 9851b0060a853625b05bc9acf7eae25955a5423f Mon Sep 17 00:00:00 2001
From: Luca Toscano <elukey@apache.org>
Date: Sun, 24 Jun 2018 07:26:03 +0000
Subject: [PATCH] mod_proxy.xml: clarify the usage of variable interpolation

PR: 62477


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1834234 13f79535-47bb-0310-9956-ffa450edef68
---
 docs/manual/mod/mod_proxy.xml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/docs/manual/mod/mod_proxy.xml b/docs/manual/mod/mod_proxy.xml
index bc3dc5239b..d0a4e1432d 100644
--- a/docs/manual/mod/mod_proxy.xml
+++ b/docs/manual/mod/mod_proxy.xml
@@ -1405,9 +1405,10 @@ ProxyPass "/" "balancer://hotcluster/"
     environment variables will not exist when this interpolation happens,
     so you may still have to resort to <module>mod_rewrite</module>
     for complex rules.  Also note that interpolation is not supported
-    within the scheme portion of a URL.  Dynamic determination of the
-    scheme can be accomplished with <module>mod_rewrite</module> as in the
-    following example.</p>
+    within the scheme/hostname/port portion of a URL. Dynamic determination of
+    those fields can be accomplished with <module>mod_rewrite</module>.
+    The following example describes how to use <module>mod_rewrite</module>
+    to dynamically set the scheme to http or https:</p>
 
     <highlight language="config">
 RewriteEngine On
@@ -2003,7 +2004,12 @@ header for proxied requests</description>
     and causes them to substitute the value of an environment
     variable <code>varname</code> for the string <code>${varname}</code>
     in configuration directives if the <var>interpolate</var> option is set.</p>
-    <p>Keep this turned off (for server performance) unless you need it!</p>
+    <p>The scheme/hostname/port portion of <directive>ProxyPass</directive> cannot
+    contain variables, please consider using <module>mod_rewrite</module> instead.</p>
+    <p>Keep this turned off (for server performance) unless you need it!
+    Adding variables to <directive>ProxyPass</directive> for example may lead to
+    using the default mod_proxy's workers configured (that don't allow any fine
+    tuning like connections reuse, etc..).</p>
 </usage>
 </directivesynopsis>
 
-- 
2.40.0