From 97ec0f3db53a4b789d08cac473c54cff9b7d0692 Mon Sep 17 00:00:00 2001 From: Derick Rethans Date: Tue, 20 Dec 2005 15:58:01 +0000 Subject: [PATCH] - Fixed bug #35699 (date() can't handle leap years before 1970). --- NEWS | 1 + ext/date/lib/unixtime2tm.c | 3 +++ ext/date/tests/bug35699.phpt | 14 ++++++++++++++ 3 files changed, 18 insertions(+) create mode 100644 ext/date/tests/bug35699.phpt diff --git a/NEWS b/NEWS index 287f8c93aa..68cf139dcc 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,7 @@ PHP NEWS options like '-1'). (Tony) - Fixed bug #35705 (strtotime() fails to parse soap date format without TZ). (Ilia) +- Fixed bug #35699 (date() can't handle leap years before 1970). (Derick) - Fixed bug #35694 (Improved error message for invalid fetch mode). (Ilia) - Fixed bug #35692 (iconv_mime_decode() segmentation fault; with libiconv only). (Tony) diff --git a/ext/date/lib/unixtime2tm.c b/ext/date/lib/unixtime2tm.c index 0187abbcfb..412f86f2bb 100644 --- a/ext/date/lib/unixtime2tm.c +++ b/ext/date/lib/unixtime2tm.c @@ -93,6 +93,9 @@ void timelib_unixtime2gmt(timelib_time* tm, timelib_sll ts) DEBUG(printf("tmp_days=%lld, year=%lld\n", tmp_days, cur_year);); months = timelib_is_leap(cur_year) ? month_tab_leap : month_tab; + if (timelib_is_leap(cur_year) && cur_year < 1970) { + tmp_days--; + } i = 11; while (i > 0) { DEBUG(printf("month=%lld (%d)\n", i, months[i]);); diff --git a/ext/date/tests/bug35699.phpt b/ext/date/tests/bug35699.phpt new file mode 100644 index 0000000000..5e4951e9fc --- /dev/null +++ b/ext/date/tests/bug35699.phpt @@ -0,0 +1,14 @@ +--TEST-- +Bug #35699 (date() can't handle leap years before 1970) +--FILE-- + +--EXPECT-- +1964-06-06T00:00:00+0000 +1963-06-06T00:00:00+0000 +1964-01-06T00:00:00+0000 -- 2.50.1