From 97701b507bceb466a74d587462cfcbdb79d2fa46 Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Thu, 21 Nov 2002 15:59:59 +0000 Subject: [PATCH] _RandomNameSequence(): style guide changes, small speedup, don't put more in the critical section than absolutely needed, acquire the mutex before the "try". --- Lib/tempfile.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Lib/tempfile.py b/Lib/tempfile.py index 2ad525eade..97f125250b 100644 --- a/Lib/tempfile.py +++ b/Lib/tempfile.py @@ -88,30 +88,30 @@ class _RandomNameSequence: _RandomNameSequence is an iterator.""" - characters = ( "abcdefghijklmnopqrstuvwxyz" - + "ABCDEFGHIJKLMNOPQRSTUVWXYZ" - + "0123456789-_") + characters = ("abcdefghijklmnopqrstuvwxyz" + + "ABCDEFGHIJKLMNOPQRSTUVWXYZ" + + "0123456789-_") def __init__(self): self.mutex = _allocate_lock() self.rng = _Random() self.normcase = _os.path.normcase + def __iter__(self): return self def next(self): m = self.mutex c = self.characters - r = self.rng + choose = self.rng.choice + m.acquire() try: - m.acquire() - letters = ''.join([r.choice(c), r.choice(c), r.choice(c), - r.choice(c), r.choice(c), r.choice(c)]) + letters = [choose(c) for dummy in "123456"] finally: m.release() - return self.normcase(letters) + return self.normcase(''.join(letters)) def _candidate_tempdir_list(): """Generate a list of candidate temporary directories which -- 2.49.0