From 974d863fec8451560c7aa31f4751d99779cb4273 Mon Sep 17 00:00:00 2001 From: "Jason R. Coombs" Date: Mon, 7 Nov 2011 10:44:25 -0500 Subject: [PATCH] Issue #13211: Add .reason attribute to HTTPError to implement parent class (URLError) interface. --- Lib/test/test_urllib2.py | 11 +++++++++++ Lib/urllib2.py | 6 ++++++ 2 files changed, 17 insertions(+) diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py index e2473159dd..7f230e2d4a 100644 --- a/Lib/test/test_urllib2.py +++ b/Lib/test/test_urllib2.py @@ -1318,6 +1318,17 @@ class RequestTests(unittest.TestCase): req = Request(url) self.assertEqual(req.get_full_url(), url) +def test_HTTPError_interface(): + """ + Issue 13211 reveals that HTTPError didn't implement the URLError + interface even though HTTPError is a subclass of URLError. + + >>> err = urllib2.HTTPError(msg='something bad happened', url=None, code=None, hdrs=None, fp=None) + >>> assert hasattr(err, 'reason') + >>> err.reason + 'something bad happened' + """ + def test_main(verbose=None): from test import test_urllib2 test_support.run_doctest(test_urllib2, verbose) diff --git a/Lib/urllib2.py b/Lib/urllib2.py index a0065b5b84..5471acd403 100644 --- a/Lib/urllib2.py +++ b/Lib/urllib2.py @@ -166,6 +166,12 @@ class HTTPError(URLError, addinfourl): def __str__(self): return 'HTTP Error %s: %s' % (self.code, self.msg) + # since URLError specifies a .reason attribute, HTTPError should also + # provide this attribute. See issue13211 fo discussion. + @property + def reason(self): + return self.msg + # copied from cookielib.py _cut_port_re = re.compile(r":\d+$") def request_host(request): -- 2.50.1