From 96cb9fb62008276266257ae7b53fa4b64224290d Mon Sep 17 00:00:00 2001 From: Zhongxing Xu Date: Fri, 28 Nov 2008 08:41:39 +0000 Subject: [PATCH] Fix a serious bug. When initialized, the index of the ElementRegion was unsigned. But the index value of the ArraySubscriptExpr is signed. This inconsistency caused the value of the array element retrieved to be UnknownVal despite it was initialized to symbolic. This is only a hack. Real fix of this problem is required. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@60207 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/RegionStore.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Analysis/RegionStore.cpp b/lib/Analysis/RegionStore.cpp index 157248f21b..981d69c822 100644 --- a/lib/Analysis/RegionStore.cpp +++ b/lib/Analysis/RegionStore.cpp @@ -669,8 +669,9 @@ Store RegionStoreManager::BindArrayToVal(Store store, const TypedRegion* BaseR, llvm::APInt Size = CAT->getSize(); llvm::APInt i = llvm::APInt::getNullValue(Size.getBitWidth()); + for (; i != Size; ++i) { - nonloc::ConcreteInt Idx(getBasicVals().getValue(llvm::APSInt(i))); + nonloc::ConcreteInt Idx(getBasicVals().getValue(llvm::APSInt(i, false))); ElementRegion* ER = MRMgr.getElementRegion(Idx, BaseR); @@ -693,7 +694,7 @@ Store RegionStoreManager::BindArrayToSymVal(Store store, llvm::APInt Size = CAT->getSize(); llvm::APInt i = llvm::APInt::getNullValue(Size.getBitWidth()); for (; i != Size; ++i) { - nonloc::ConcreteInt Idx(getBasicVals().getValue(llvm::APSInt(i))); + nonloc::ConcreteInt Idx(getBasicVals().getValue(llvm::APSInt(i, false))); ElementRegion* ER = MRMgr.getElementRegion(Idx, BaseR); -- 2.50.1