From 95f83b3c1363f34ec49aac820690b79bd0fd9f70 Mon Sep 17 00:00:00 2001 From: Kostya Serebryany Date: Mon, 31 Jul 2017 20:00:22 +0000 Subject: [PATCH] [sanitizer-coverage] don't instrument available_externally functions git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@309611 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Instrumentation/SanitizerCoverage.cpp | 3 +++ test/Instrumentation/SanitizerCoverage/tracing.ll | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/lib/Transforms/Instrumentation/SanitizerCoverage.cpp b/lib/Transforms/Instrumentation/SanitizerCoverage.cpp index fb7f8ec85d4..1b6d6d6f3c6 100644 --- a/lib/Transforms/Instrumentation/SanitizerCoverage.cpp +++ b/lib/Transforms/Instrumentation/SanitizerCoverage.cpp @@ -418,6 +418,9 @@ bool SanitizerCoverageModule::runOnFunction(Function &F) { return false; // Should not instrument sanitizer init functions. if (F.getName().startswith("__sanitizer_")) return false; // Don't instrument __sanitizer_* callbacks. + // Don't touch available_externally functions, their actual body is elewhere. + if (F.getLinkage() == GlobalValue::AvailableExternallyLinkage) + return false; // Don't instrument MSVC CRT configuration helpers. They may run before normal // initialization. if (F.getName() == "__local_stdio_printf_options" || diff --git a/test/Instrumentation/SanitizerCoverage/tracing.ll b/test/Instrumentation/SanitizerCoverage/tracing.ll index 209b9874cb2..860904c0f19 100644 --- a/test/Instrumentation/SanitizerCoverage/tracing.ll +++ b/test/Instrumentation/SanitizerCoverage/tracing.ll @@ -18,6 +18,12 @@ entry: ret void } +define available_externally void @external_bar(i32* %a) sanitize_address { +entry: + ret void +} + + ; CHECK_PC-LABEL: define void @foo ; CHECK_PC: call void @__sanitizer_cov_trace_pc ; CHECK_PC: call void @__sanitizer_cov_trace_pc @@ -33,6 +39,10 @@ entry: ; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guard ; CHECK_PC_GUARD-NOT: call void @__sanitizer_cov_trace_pc ; CHECK_PC_GUARD: ret void +; CHECK_PC_GUARD-LABEL: @external_bar +; CHECK_PC_GUARD-NOT: call void @__sanitizer_cov_trace_pc +; CHECK_PC_GUARD: ret void + ; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guard_init(i32* bitcast (i32** @__start___sancov_guards to i32*), i32* bitcast (i32** @__stop___sancov_guards to i32*)) ; CHECK_PC_GUARD_DARWIN-LABEL: define void @foo -- 2.40.0