From 95a011204fec58cc5dbc4f4a9830a8f0435c4b72 Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Thu, 4 Feb 2010 04:18:55 +0000 Subject: [PATCH] Specially handle casts to 'void' in AdjustedReturnValueChecker. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@95287 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Checker/AdjustedReturnValueChecker.cpp | 11 +++++++++-- test/Analysis/misc-ps.m | 8 ++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/lib/Checker/AdjustedReturnValueChecker.cpp b/lib/Checker/AdjustedReturnValueChecker.cpp index 898ce76a99..483b41b6bd 100644 --- a/lib/Checker/AdjustedReturnValueChecker.cpp +++ b/lib/Checker/AdjustedReturnValueChecker.cpp @@ -43,12 +43,21 @@ void clang::RegisterAdjustedReturnValueChecker(GRExprEngine &Eng) { void AdjustedReturnValueChecker::PostVisitCallExpr(CheckerContext &C, const CallExpr *CE) { + // Get the result type of the call. + QualType expectedResultTy = CE->getType(); + // Fetch the signature of the called function. const GRState *state = C.getState(); SVal V = state->getSVal(CE); if (V.isUnknown()) return; + + // Casting to void? Discard the value. + if (expectedResultTy->isVoidType()) { + C.GenerateNode(state->BindExpr(CE, UnknownVal())); + return; + } const MemRegion *callee = state->getSVal(CE->getCallee()).getAsRegion(); if (!callee) @@ -76,8 +85,6 @@ void AdjustedReturnValueChecker::PostVisitCallExpr(CheckerContext &C, if (actualResultTy->getAs()) return; - // Get the result type of the call. - QualType expectedResultTy = CE->getType(); // Are they the same? if (expectedResultTy != actualResultTy) { diff --git a/test/Analysis/misc-ps.m b/test/Analysis/misc-ps.m index 949c51019f..8c76ff6de6 100644 --- a/test/Analysis/misc-ps.m +++ b/test/Analysis/misc-ps.m @@ -893,3 +893,11 @@ int bar_rev95267() { return 1; return 0; } + +// Same as previous case, but handle casts to 'void'. +int bar_rev95274() { + void (*Callback_rev95274)(void) = (void (*)(void)) foo_rev95267; + (*Callback_rev95274)(); + return 0; +} + -- 2.40.0