From 9275184cf22bcc045842bee7a26067e62381178a Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 20 Mar 2019 17:44:24 +0000 Subject: [PATCH] [Remarks] Fix mismatched delete due to missing virtual destructor This fixes an asan failure introduced in r356519. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356583 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Remarks/RemarkParserImpl.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/Remarks/RemarkParserImpl.h b/lib/Remarks/RemarkParserImpl.h index 6804657f9bf..b4c106badf6 100644 --- a/lib/Remarks/RemarkParserImpl.h +++ b/lib/Remarks/RemarkParserImpl.h @@ -19,6 +19,10 @@ namespace remarks { struct ParserImpl { enum class Kind { YAML }; + explicit ParserImpl(Kind TheParserKind) : ParserKind(TheParserKind) {} + // Virtual destructor prevents mismatched deletes + virtual ~ParserImpl() {} + // The parser kind. This is used as a tag to safely cast between // implementations. Kind ParserKind; -- 2.40.0