From 91ca700dd9f1f5b099beeb0ddff3564b86da8f1c Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Thu, 26 Mar 2009 10:17:47 +0000 Subject: [PATCH] Fixed bug #47771 (Exception during object construction from arg call calls object's destructor) --- Zend/tests/bug47771.phpt | 30 ++++++++++++++++++++++++++++++ Zend/zend_vm_def.h | 9 +++++++-- Zend/zend_vm_execute.h | 9 +++++++-- 3 files changed, 44 insertions(+), 4 deletions(-) create mode 100644 Zend/tests/bug47771.phpt diff --git a/Zend/tests/bug47771.phpt b/Zend/tests/bug47771.phpt new file mode 100644 index 0000000000..a17fcf3b58 --- /dev/null +++ b/Zend/tests/bug47771.phpt @@ -0,0 +1,30 @@ +--TEST-- +Bug #47771 (Exception during object construction from arg call calls object's destructor) +--FILE-- +getMessage() . "\n"; +} +?> +--EXPECT-- +Exception: TEST_EXCEPTION diff --git a/Zend/zend_vm_def.h b/Zend/zend_vm_def.h index ee2681ddaa..7d674326ba 100644 --- a/Zend/zend_vm_def.h +++ b/Zend/zend_vm_def.h @@ -4472,8 +4472,13 @@ ZEND_VM_HANDLER(149, ZEND_HANDLE_EXCEPTION, ANY, ANY) while (EX(fbc)) { EX(called_scope) = (zend_class_entry*)zend_ptr_stack_pop(&EG(arg_types_stack)); if (EX(object)) { - if (IS_CTOR_USED(EX(called_scope))) { - Z_DELREF_P(EX(object)); + if (IS_CTOR_CALL(EX(called_scope))) { + if (IS_CTOR_USED(EX(called_scope))) { + Z_DELREF_P(EX(object)); + } + if (Z_REFCOUNT_P(EX(object)) == 1) { + zend_object_store_ctor_failed(EX(object) TSRMLS_CC); + } } zval_ptr_dtor(&EX(object)); } diff --git a/Zend/zend_vm_execute.h b/Zend/zend_vm_execute.h index 56194b68e1..c39d5449dc 100644 --- a/Zend/zend_vm_execute.h +++ b/Zend/zend_vm_execute.h @@ -633,8 +633,13 @@ static int ZEND_FASTCALL ZEND_HANDLE_EXCEPTION_SPEC_HANDLER(ZEND_OPCODE_HANDLER while (EX(fbc)) { EX(called_scope) = (zend_class_entry*)zend_ptr_stack_pop(&EG(arg_types_stack)); if (EX(object)) { - if (IS_CTOR_USED(EX(called_scope))) { - Z_DELREF_P(EX(object)); + if (IS_CTOR_CALL(EX(called_scope))) { + if (IS_CTOR_USED(EX(called_scope))) { + Z_DELREF_P(EX(object)); + } + if (Z_REFCOUNT_P(EX(object)) == 1) { + zend_object_store_ctor_failed(EX(object) TSRMLS_CC); + } } zval_ptr_dtor(&EX(object)); } -- 2.50.1