From 914799e62a8e9172efc068a5cc748b3027467613 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 5 Jul 2019 11:28:31 +0000 Subject: [PATCH] lld-link: Make /debugtype: option work better - The code tried to pass false to split()'s KeepEmpty parameter, but instead passed it to MaxSplit. As a result, it would never split on commas. This has been broken since the flag was added in r278056. - The code used getSpelling() for getting the argument's values, but getSpelling() always returns the `/debugtype:` prefix without any values. So if any /debugtype: flag was passed, it always resulted in an "unknown option:" warning. (The warning code then used the correct getValue() for printing the invalid option, so the warning looked kind of like it made sense.) This regressed in r342894. Slightly improve the test coverage of this feature (but since I don't know what this flag actually does, there's still no test for the correct semantics), and add a comment to getSpelling() explaining what it does. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@365182 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Option/Arg.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/llvm/Option/Arg.h b/include/llvm/Option/Arg.h index d3623a0c1e4..8c4787051cf 100644 --- a/include/llvm/Option/Arg.h +++ b/include/llvm/Option/Arg.h @@ -70,7 +70,15 @@ public: ~Arg(); const Option &getOption() const { return Opt; } + + /// Returns the used prefix and name of the option: + /// For `--foo=bar`, returns `--foo=`. + /// This is often the wrong function to call: + /// * Use `getValue()` to get `bar`. + /// * Use `getAsString()` to get a string suitable for printing an Arg in + /// a diagnostic. StringRef getSpelling() const { return Spelling; } + unsigned getIndex() const { return Index; } /// Return the base argument which generated this arg. -- 2.40.0