From 90da27b9277d74521202e5c146a09056696898ee Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Fri, 25 Mar 2022 14:54:18 +0000 Subject: [PATCH] patch 8.2.4625: old Coverity warning for resource leak Problem: Old Coverity warning for resource leak. Solution: Call FreeWild() if expanding matches did not fail. --- src/help.c | 9 ++++++--- src/version.c | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/help.c b/src/help.c index 661d5b5c3..48178fda3 100644 --- a/src/help.c +++ b/src/help.c @@ -947,6 +947,7 @@ helptags_one( FILE *fd_tags; FILE *fd; garray_T ga; + int res; int filecount; char_u **files; char_u *p1, *p2; @@ -965,12 +966,14 @@ helptags_one( STRCPY(NameBuff, dir); STRCAT(NameBuff, "/**/*"); STRCAT(NameBuff, ext); - if (gen_expand_wildcards(1, &NameBuff, &filecount, &files, - EW_FILE|EW_SILENT) == FAIL - || filecount == 0) + res = gen_expand_wildcards(1, &NameBuff, &filecount, &files, + EW_FILE|EW_SILENT); + if (res == FAIL || filecount == 0) { if (!got_int) semsg(_(e_no_match_str_1), NameBuff); + if (res != FAIL) + FreeWild(filecount, files); return; } diff --git a/src/version.c b/src/version.c index 4a20c4665..748a12f39 100644 --- a/src/version.c +++ b/src/version.c @@ -750,6 +750,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 4625, /**/ 4624, /**/ -- 2.40.0