From 8f58b974b22611db414dee3e0173f10479aea432 Mon Sep 17 00:00:00 2001 From: Rasmus Lerdorf Date: Fri, 12 Mar 2004 17:29:52 +0000 Subject: [PATCH] Fix/workaround for http://bugs.php.net/27533 --- ext/standard/datetime.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ext/standard/datetime.c b/ext/standard/datetime.c index 82b06fb6d1..63f127d23b 100644 --- a/ext/standard/datetime.c +++ b/ext/standard/datetime.c @@ -189,8 +189,14 @@ void php_mktime(INTERNAL_FUNCTION_PARAMETERS, int gm) /* fall-through */ case 1: /* hour */ val = (*arguments[0])->value.lval; - if (val < 1) { - chgsecs += (1-val) * 60*60; val = 1; + /* + We don't use 1 here to work around problems in some mktime implementations + when it comes to daylight savings time. Setting it to 2 and working back from + there with the chgsecs offset makes us immune to these problems. + See http://bugs.php.net/27533 for more info. + */ + if (val < 2) { + chgsecs += (2-val) * 60*60; val = 2; } ta->tm_hour = val; /* fall-through */ -- 2.40.0