From 8e639052638a9bb8c7dd6e3e10776b1218cec1a3 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Sun, 13 Nov 2016 14:31:40 +0100 Subject: [PATCH] patch 8.0.0083 Problem: Using freed memory with win_getid(). (Domenique Pelle) Solution: For the current tab use curwin. --- src/testdir/test_window_id.vim | 9 +++++++++ src/version.c | 2 ++ src/window.c | 5 ++++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/testdir/test_window_id.vim b/src/testdir/test_window_id.vim index 66656e1d0..b3b506d04 100644 --- a/src/testdir/test_window_id.vim +++ b/src/testdir/test_window_id.vim @@ -92,3 +92,12 @@ func Test_win_getid() only! endfunc + +func Test_win_getid_curtab() + tabedit X + tabfirst + copen + only + call assert_equal(win_getid(1), win_getid(1, 1)) + tabclose! +endfunc diff --git a/src/version.c b/src/version.c index e85192247..c7f00a876 100644 --- a/src/version.c +++ b/src/version.c @@ -764,6 +764,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 83, /**/ 82, /**/ diff --git a/src/window.c b/src/window.c index 8e5336883..ee5f7aa8a 100644 --- a/src/window.c +++ b/src/window.c @@ -7133,7 +7133,10 @@ win_getid(typval_T *argvars) break; if (tp == NULL) return -1; - wp = tp->tp_firstwin; + if (tp == curtab) + wp = firstwin; + else + wp = tp->tp_firstwin; } for ( ; wp != NULL; wp = wp->w_next) if (--winnr == 0) -- 2.50.1