From 8e482bea21cb942804234e36d3c6c896aabd32da Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 24 Oct 2017 03:33:36 -0700 Subject: [PATCH] bpo-31174: Fix test_tools.test_unparse (#4102) test_unparse.DirectoryTestCase now stores the names sample to always test the same files. It prevents false alarms when hunting reference leaks. --- Lib/test/test_tools/test_unparse.py | 15 +++++++++++++-- .../2017-10-24-11-36-10.bpo-31174.xCvXcr.rst | 3 +++ 2 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Tests/2017-10-24-11-36-10.bpo-31174.xCvXcr.rst diff --git a/Lib/test/test_tools/test_unparse.py b/Lib/test/test_tools/test_unparse.py index 65dee1b5ae..bab49df331 100644 --- a/Lib/test/test_tools/test_unparse.py +++ b/Lib/test/test_tools/test_unparse.py @@ -263,12 +263,14 @@ class UnparseTestCase(ASTTestCase): class DirectoryTestCase(ASTTestCase): """Test roundtrip behaviour on all files in Lib and Lib/test.""" + NAMES = None # test directories, relative to the root of the distribution test_directories = 'Lib', os.path.join('Lib', 'test') - def test_files(self): - # get names of files to test + def get_names(self): + if DirectoryTestCase.NAMES is not None: + return DirectoryTestCase.NAMES names = [] for d in self.test_directories: @@ -280,6 +282,15 @@ class DirectoryTestCase(ASTTestCase): # Test limited subset of files unless the 'cpu' resource is specified. if not test.support.is_resource_enabled("cpu"): names = random.sample(names, 10) + # bpo-31174: Store the names sample to always test the same files. + # It prevents false alarms when hunting reference leaks. + DirectoryTestCase.NAMES = names + + return names + + def test_files(self): + # get names of files to test + names = self.get_names() for filename in names: if test.support.verbose: diff --git a/Misc/NEWS.d/next/Tests/2017-10-24-11-36-10.bpo-31174.xCvXcr.rst b/Misc/NEWS.d/next/Tests/2017-10-24-11-36-10.bpo-31174.xCvXcr.rst new file mode 100644 index 0000000000..e098064908 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2017-10-24-11-36-10.bpo-31174.xCvXcr.rst @@ -0,0 +1,3 @@ +Fix test_tools.test_unparse: DirectoryTestCase now stores the names sample +to always test the same files. It prevents false alarms when hunting +reference leaks. -- 2.40.0