From 8dc951194b45c7acc36cd3a140f51d5db1d3f65b Mon Sep 17 00:00:00 2001 From: Rasmus Lerdorf Date: Sun, 7 Aug 2011 00:36:26 +0000 Subject: [PATCH] I'm pretty sure you didn't mean to multiple by the size of a char* there since that makes no sense. output is an array of char, not an array of char* Pierre, please review --- ext/standard/crypt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/standard/crypt.c b/ext/standard/crypt.c index fda95d8f9c..865a25beb1 100644 --- a/ext/standard/crypt.c +++ b/ext/standard/crypt.c @@ -198,7 +198,7 @@ PHP_FUNCTION(crypt) int needed = (sizeof(sha512_salt_prefix) - 1 + sizeof(sha512_rounds_prefix) + 9 + 1 + strlen(salt) + 1 + 43 + 1); - output = emalloc(needed * sizeof(char *)); + output = emalloc(needed); salt[salt_in_len] = '\0'; crypt_res = php_sha512_crypt_r(str, salt, output, needed); @@ -221,7 +221,7 @@ PHP_FUNCTION(crypt) int needed = (sizeof(sha256_salt_prefix) - 1 + sizeof(sha256_rounds_prefix) + 9 + 1 + strlen(salt) + 1 + 43 + 1); - output = emalloc(needed * sizeof(char *)); + output = emalloc(needed); salt[salt_in_len] = '\0'; crypt_res = php_sha256_crypt_r(str, salt, output, needed); -- 2.50.1