From 8d143e15c8abbcabfc9953266dd9f432306b6237 Mon Sep 17 00:00:00 2001 From: Stefan Fritsch Date: Mon, 5 Apr 2010 21:17:08 +0000 Subject: [PATCH] fix more errors found by cppcheck git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@930962 13f79535-47bb-0310-9956-ffa450edef68 --- modules/ldap/util_ldap.c | 4 +++- server/util_expr.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c index 713523698a..3aa1d3cc1f 100644 --- a/modules/ldap/util_ldap.c +++ b/modules/ldap/util_ldap.c @@ -231,10 +231,12 @@ static apr_status_t uldap_connection_cleanup(void *param) */ static apr_status_t util_ldap_connection_remove (void *param) { util_ldap_connection_t *ldc = param, *l = NULL, *prev = NULL; - util_ldap_state_t *st = ldc->st; + util_ldap_state_t *st; if (!ldc) return APR_SUCCESS; + st = ldc->st; + uldap_connection_unbind(ldc); #if APR_HAS_THREADS diff --git a/server/util_expr.c b/server/util_expr.c index 3acc8a3182..6d8329dfc9 100644 --- a/server/util_expr.c +++ b/server/util_expr.c @@ -44,7 +44,7 @@ } while(0) #define CREATE_NODE(pool,name) do { \ - (name) = apr_pcalloc(pool, sizeof(*(name))); + (name) = apr_pcalloc(pool, sizeof(*(name))); \ } while(0) static void debug_printf(request_rec *r, const char *fmt, ...) -- 2.40.0