From 8c9091074b6a0e7e48eb2cce03a4eb193cb993be Mon Sep 17 00:00:00 2001 From: Andrew Dalke Date: Thu, 25 May 2006 17:53:00 +0000 Subject: [PATCH] Fixed problem identified by Georg. The special-case in-place code for replace made a copy of the string using PyString_FromStringAndSize(s, n) and modify the copied string in-place. However, 1 (and 0) character strings are shared from a cache. This cause "A".replace("A", "a") to change the cached version of "A" -- used by everyone. Now may the copy with NULL as the string and do the memcpy manually. I've added regression tests to check if this happens in the future. Perhaps there should be a PyString_Copy for this case? --- Objects/stringobject.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Objects/stringobject.c b/Objects/stringobject.c index aed0c23618..b0c4640a0c 100644 --- a/Objects/stringobject.c +++ b/Objects/stringobject.c @@ -2692,10 +2692,11 @@ replace_single_character_in_place(PyStringObject *self, } /* Need to make a new string */ - result = (PyStringObject *) PyString_FromStringAndSize(self_s, self_len); + result = (PyStringObject *) PyString_FromStringAndSize(NULL, self_len); if (result == NULL) return NULL; result_s = PyString_AS_STRING(result); + memcpy(result_s, self_s, self_len); /* change everything in-place, starting with this one */ start = result_s + (next-self_s); @@ -2745,10 +2746,12 @@ replace_substring_in_place(PyStringObject *self, } /* Need to make a new string */ - result = (PyStringObject *) PyString_FromStringAndSize(self_s, self_len); + result = (PyStringObject *) PyString_FromStringAndSize(NULL, self_len); if (result == NULL) return NULL; result_s = PyString_AS_STRING(result); + memcpy(result_s, self_s, self_len); + /* change everything in-place, starting with this one */ start = result_s + offset; -- 2.40.0