From 8b65de4a66813f50598c01f8e2e56adac8955f2b Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Sat, 15 Mar 2008 22:07:05 +0000 Subject: [PATCH] Disable creation of "ContentsOf" symbols. It was fundamentally broken on many levels; eventually we will need a plug-in model (similar to GRTransferFuncs) to represent symbolic memory. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@48399 91177308-0d34-0410-b5e6-96231b3b80d8 --- Analysis/ValueState.cpp | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/Analysis/ValueState.cpp b/Analysis/ValueState.cpp index 1fc4df9128..97df578eca 100644 --- a/Analysis/ValueState.cpp +++ b/Analysis/ValueState.cpp @@ -163,17 +163,29 @@ RVal ValueStateManager::GetRVal(ValueState* St, LVal LV, QualType T) { // FIXME: We should limit how far a "ContentsOf" will go... case lval::SymbolValKind: { + + + // FIXME: This is a broken representation of memory, and is prone + // to crashing the analyzer when addresses to symbolic values are + // passed through casts. We need a better representation of symbolic + // memory (or just memory in general); probably we should do this + // as a plugin class (similar to GRTransferFuncs). + +#if 0 const lval::SymbolVal& SV = cast(LV); assert (T.getTypePtr()); // Punt on "symbolic" function pointers. if (T->isFunctionType()) - return UnknownVal(); - + return UnknownVal(); + if (T->isPointerType()) return lval::SymbolVal(SymMgr.getContentsOfSymbol(SV.getSymbol())); else return nonlval::SymbolVal(SymMgr.getContentsOfSymbol(SV.getSymbol())); +#endif + + return UnknownVal(); } default: -- 2.40.0