From 8a8c581a8c99b9beecbdc517957da866f427f297 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Fri, 26 Jun 2015 14:45:32 -0400 Subject: [PATCH] Remove unnecessary NULL test. Spotted by Coverity and reported by Michael Paquier. Per discussion, we don't necessarily care about making Coverity happy in all such instances, but we can go ahead and change them where it otherwise seems to improve the code. --- src/bin/pg_upgrade/controldata.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/bin/pg_upgrade/controldata.c b/src/bin/pg_upgrade/controldata.c index 142e623c09..6978ae991b 100644 --- a/src/bin/pg_upgrade/controldata.c +++ b/src/bin/pg_upgrade/controldata.c @@ -402,8 +402,7 @@ get_control_data(ClusterInfo *cluster, bool live_check) } } - if (output) - pclose(output); + pclose(output); /* * Restore environment variables -- 2.40.0