From 89a5bd67500510f30a729ff97048fa230c9f9bd3 Mon Sep 17 00:00:00 2001 From: Anatol Belski Date: Wed, 15 Feb 2017 11:22:47 +0100 Subject: [PATCH] Fixed bug #74090 stream_get_contents maxlength>-1 returns empty string --- ext/standard/tests/streams/bug74090.phpt | 22 ++++++++++++++++++++++ main/streams/php_streams_int.h | 4 ++++ main/streams/xp_socket.c | 2 +- 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 ext/standard/tests/streams/bug74090.phpt diff --git a/ext/standard/tests/streams/bug74090.phpt b/ext/standard/tests/streams/bug74090.phpt new file mode 100644 index 0000000000..370dd13f1b --- /dev/null +++ b/ext/standard/tests/streams/bug74090.phpt @@ -0,0 +1,22 @@ +--TEST-- +Bug #74090 stream_get_contents maxlength>-1 returns empty string on windows +--SKIPIF-- + +--FILE-- + 0); +stream_socket_shutdown($fd,STREAM_SHUT_RDWR); +?> +==DONE== +--EXPECTF-- +bool(true) +==DONE== diff --git a/main/streams/php_streams_int.h b/main/streams/php_streams_int.h index 42fdfcb4c7..13a817833f 100644 --- a/main/streams/php_streams_int.h +++ b/main/streams/php_streams_int.h @@ -53,6 +53,10 @@ # undef EWOULDBLOCK # endif # define EWOULDBLOCK WSAEWOULDBLOCK +# ifdef EMSGSIZE +# undef EMSGSIZE +# endif +# define EMSGSIZE WSAEMSGSIZE #endif /* This functions transforms the first char to 'w' if it's not 'r', 'a' or 'w' diff --git a/main/streams/xp_socket.c b/main/streams/xp_socket.c index a791621a20..701a993ccc 100644 --- a/main/streams/xp_socket.c +++ b/main/streams/xp_socket.c @@ -336,7 +336,7 @@ static int php_sockop_set_option(php_stream *stream, int option, int value, void ret = recv(sock->socket, &buf, sizeof(buf), MSG_PEEK); err = php_socket_errno(); if (0 == ret || /* the counterpart did properly shutdown*/ - (0 > ret && err != EWOULDBLOCK && err != EAGAIN)) { /* there was an unrecoverable error */ + (0 > ret && err != EWOULDBLOCK && err != EAGAIN && err != EMSGSIZE)) { /* there was an unrecoverable error */ alive = 0; } } -- 2.40.0