From 897f0b4c27b42e9ccf441fe11ab757a401cf39d5 Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Fri, 19 Nov 2010 22:06:44 +0000 Subject: [PATCH] - Fixed extract() to do not overwrite $GLOBALS and $this when using EXTR_OVERWRITE. patch by: jorto at redhat dot com --- ext/standard/array.c | 4 ++-- ext/standard/tests/array/extract_safety.phpt | 24 ++++++++++++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 ext/standard/tests/array/extract_safety.phpt diff --git a/ext/standard/array.c b/ext/standard/array.c index c9074394b2..83b2bf65b6 100644 --- a/ext/standard/array.c +++ b/ext/standard/array.c @@ -1389,10 +1389,10 @@ PHP_FUNCTION(extract) case EXTR_OVERWRITE: /* GLOBALS protection */ - if (var_exists && var_name_len == sizeof("GLOBALS") && !strcmp(var_name, "GLOBALS")) { + if (var_exists && var_name_len == sizeof("GLOBALS")-1 && !strcmp(var_name, "GLOBALS")) { break; } - if (var_exists && var_name_len == sizeof("this") && !strcmp(var_name, "this") && EG(scope) && EG(scope)->name_length != 0) { + if (var_exists && var_name_len == sizeof("this")-1 && !strcmp(var_name, "this") && EG(scope) && EG(scope)->name_length != 0) { break; } ZVAL_STRINGL(&final_name, var_name, var_name_len, 1); diff --git a/ext/standard/tests/array/extract_safety.phpt b/ext/standard/tests/array/extract_safety.phpt new file mode 100644 index 0000000000..d5d0763be0 --- /dev/null +++ b/ext/standard/tests/array/extract_safety.phpt @@ -0,0 +1,24 @@ +--TEST-- +Test extract() for overwrite of GLOBALS +--FILE-- + "bar"); +var_dump(extract(array("GLOBALS" => $splat, EXTR_OVERWRITE))); + +unset ($splat); + +debug_zval_dump($GLOBALS["str"]); + +echo "\nDone"; +?> + +--EXPECTF-- +string(4) "John" refcount(2) +int(0) +string(4) "John" refcount(2) + +Done \ No newline at end of file -- 2.40.0