From 88e09fe79b909fbfe266e87a2731f96c197726fb Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Thu, 7 Dec 2017 14:23:35 -0600 Subject: [PATCH] Fix coverity nit in handshake_helper.c There's no reason to wrap this call in TEST_true() if we're not checking the return value of TEST_true() -- all of the surrounding similar calls do not have the macro wrapping them. Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/4873) --- test/handshake_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/handshake_helper.c b/test/handshake_helper.c index 78eaa012e2..0add973e50 100644 --- a/test/handshake_helper.c +++ b/test/handshake_helper.c @@ -497,8 +497,8 @@ static int configure_handshake_ctx(SSL_CTX *server_ctx, SSL_CTX *server2_ctx, case TLSEXT_max_fragment_length_2048: case TLSEXT_max_fragment_length_4096: case TLSEXT_max_fragment_length_DISABLED: - TEST_true(SSL_CTX_set_tlsext_max_fragment_length( - client_ctx, extra->client.max_fragment_len_mode)); + SSL_CTX_set_tlsext_max_fragment_length( + client_ctx, extra->client.max_fragment_len_mode); break; } -- 2.40.0