From 87f106462ce49a4a9b812b9de92aadd4e54567bd Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Thu, 14 Apr 2011 23:19:27 +0000 Subject: [PATCH] If the declaration of a C++ member function with an inline definition is so broken that Sema can't form a declaration for it, don't bother trying to parse the definition later. Fixes . git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@129547 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Parse/ParseCXXInlineMethods.cpp | 8 ++++++++ test/Parser/cxx-member-crash.cpp | 15 +++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 test/Parser/cxx-member-crash.cpp diff --git a/lib/Parse/ParseCXXInlineMethods.cpp b/lib/Parse/ParseCXXInlineMethods.cpp index fc1902ca7f..93568efebc 100644 --- a/lib/Parse/ParseCXXInlineMethods.cpp +++ b/lib/Parse/ParseCXXInlineMethods.cpp @@ -87,6 +87,14 @@ Decl *Parser::ParseCXXInlineMethodDef(AccessSpecifier AS, ParsingDeclarator &D, } } + + if (!FnD) { + // If semantic analysis could not build a function declaration, + // just throw away the late-parsed declaration. + delete getCurrentClass().LateParsedDeclarations.back(); + getCurrentClass().LateParsedDeclarations.pop_back(); + } + return FnD; } diff --git a/test/Parser/cxx-member-crash.cpp b/test/Parser/cxx-member-crash.cpp new file mode 100644 index 0000000000..2b31a608a5 --- /dev/null +++ b/test/Parser/cxx-member-crash.cpp @@ -0,0 +1,15 @@ +// RUN: %clang_cc1 -fsyntax-only %s 2>&1|FileCheck %s + +// + +// We only care to chek whether the compiler crashes; the actual +// diagnostics are uninteresting. +// CHECK: 8 errors generated. +template struct char_traits; +template > class basic_ios; +template > class ostreambuf_iterator; +template > class num_get; +template class basic_ostream : virtual public basic_ios<_CharT, _Traits> { + template _InIter num_get<_CharT, _InIter>:: _M_extract_float(_InIter __beg, _InIter __end, ios_base& __io, ios_base::iostate& __err, string& __xtrc) const { + const bool __plus = __c == __lit[__num_base::_S_iplus]; + if ((__plus || __c == __lit[__num_base::_S_iminus]) && !(__lc->_M_use_grouping && __c == __lc->_M_thousands_sep) && !(__c == __lc->_M_decimal_point)) { -- 2.40.0