From 87dca00a8e3a22ac0d988f417d94883b896eb88c Mon Sep 17 00:00:00 2001 From: Matt Wilmas Date: Thu, 29 May 2008 11:45:13 +0000 Subject: [PATCH] MFH: Fixed overflow crash (at least on Windows) in div_function with LONG_MIN / -1 --- Zend/zend_operators.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Zend/zend_operators.c b/Zend/zend_operators.c index 6a905cef9d..08ea3b0df8 100644 --- a/Zend/zend_operators.c +++ b/Zend/zend_operators.c @@ -934,6 +934,10 @@ ZEND_API int div_function(zval *result, zval *op1, zval *op2 TSRMLS_DC) zend_error(E_WARNING, "Division by zero"); ZVAL_BOOL(result, 0); return FAILURE; /* division by zero */ + } else if (Z_LVAL_P(op2) == -1 && Z_LVAL_P(op1) == LONG_MIN) { + /* Prevent overflow error/crash */ + ZVAL_DOUBLE(result, (double) LONG_MIN / -1); + return SUCCESS; } if (Z_LVAL_P(op1) % Z_LVAL_P(op2) == 0) { /* integer */ ZVAL_LONG(result, Z_LVAL_P(op1) / Z_LVAL_P(op2)); -- 2.50.1