From 86d0cb8325d04a7adf10534f9379855733201c7d Mon Sep 17 00:00:00 2001 From: Johann Date: Mon, 1 Jun 2015 16:24:49 -0700 Subject: [PATCH] Disable neon bilinear 4x4 Clang adds alignment hints when casting up the loads/stores. Although this should be safe for most paths, it's causing some crashes. Either the source of the misalignment needs to be determined and adjusted or the intrinsics need to be rewritten to avoid using the cast to load the data. BUG=817,892 Change-Id: Ia3aa824d6a4cd97e14325ff49dc730b6f85ec7e8 --- vp8/common/rtcd_defs.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vp8/common/rtcd_defs.pl b/vp8/common/rtcd_defs.pl index 4b820338e..559861b9c 100644 --- a/vp8/common/rtcd_defs.pl +++ b/vp8/common/rtcd_defs.pl @@ -215,7 +215,7 @@ $vp8_sixtap_predict8x4_media=vp8_sixtap_predict8x4_armv6; $vp8_sixtap_predict8x4_dspr2=vp8_sixtap_predict8x4_dspr2; add_proto qw/void vp8_sixtap_predict4x4/, "unsigned char *src, int src_pitch, int xofst, int yofst, unsigned char *dst, int dst_pitch"; -# Disable neon while investigating https://code.google.com/p/webm/issues/detail?id=817 +#TODO(johannkoenig): fix the neon version https://code.google.com/p/webm/issues/detail?id=817 specialize qw/vp8_sixtap_predict4x4 mmx ssse3 media dspr2/; $vp8_sixtap_predict4x4_media=vp8_sixtap_predict4x4_armv6; $vp8_sixtap_predict4x4_dspr2=vp8_sixtap_predict4x4_dspr2; @@ -233,7 +233,8 @@ specialize qw/vp8_bilinear_predict8x4 mmx media neon/; $vp8_bilinear_predict8x4_media=vp8_bilinear_predict8x4_armv6; add_proto qw/void vp8_bilinear_predict4x4/, "unsigned char *src, int src_pitch, int xofst, int yofst, unsigned char *dst, int dst_pitch"; -specialize qw/vp8_bilinear_predict4x4 mmx media neon/; +#TODO(johannkoenig): fix the neon version https://code.google.com/p/webm/issues/detail?id=892 +specialize qw/vp8_bilinear_predict4x4 mmx media/; $vp8_bilinear_predict4x4_media=vp8_bilinear_predict4x4_armv6; # -- 2.49.0