From 85db5475982e166ec5bb1c8c9a5c8bf062d49ed1 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Wed, 4 Dec 2019 15:11:08 +0100 Subject: [PATCH] patch 8.1.2385: opening cmdline window with feedkeys() does not work Problem: Opening cmdline window with feedkeys() does not work. (Yegappan Lakshmanan) Solution: Recognize K_CMDWIN also when ex_normal_busy is set. --- src/ex_getln.c | 3 ++- src/testdir/test_cmdline.vim | 5 +++++ src/version.c | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/ex_getln.c b/src/ex_getln.c index 25f409b74..769dcb836 100644 --- a/src/ex_getln.c +++ b/src/ex_getln.c @@ -1361,7 +1361,8 @@ getcmdline_int( #ifdef FEAT_CMDWIN if (c == cedit_key || c == K_CMDWIN) { - if (ex_normal_busy == 0 && got_int == FALSE) + // TODO: why is ex_normal_busy checked here? + if ((c == K_CMDWIN || ex_normal_busy == 0) && got_int == FALSE) { /* * Open a window to edit the command line (and history). diff --git a/src/testdir/test_cmdline.vim b/src/testdir/test_cmdline.vim index 7a4979e01..5e2597930 100644 --- a/src/testdir/test_cmdline.vim +++ b/src/testdir/test_cmdline.vim @@ -843,3 +843,8 @@ func Test_buffers_lastused() bwipeout bufb bwipeout bufc endfunc + +func Test_cmdwin_feedkeys() + " This should not generate E488 + call feedkeys("q:\", 'x') +endfunc diff --git a/src/version.c b/src/version.c index f7c6e343a..abe541b6d 100644 --- a/src/version.c +++ b/src/version.c @@ -742,6 +742,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 2385, /**/ 2384, /**/ -- 2.40.0