From 8476f5b29e03a353171a8d7b3059c820d8b4f3a1 Mon Sep 17 00:00:00 2001 From: Sascha Schumann Date: Fri, 1 Dec 2000 12:29:29 +0000 Subject: [PATCH] Please avoid potential buffer overflows in new code. If you deal with strings, consider storing the string length along with the string data. That will make your life easier. --- ext/dba/dba.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ext/dba/dba.c b/ext/dba/dba.c index ee8f7409d1..7fc8e60d69 100644 --- a/ext/dba/dba.c +++ b/ext/dba/dba.c @@ -206,21 +206,23 @@ static PHP_MSHUTDOWN_FUNCTION(dba) return SUCCESS; } +#include "ext/standard/php_smart_str.h" static PHP_MINFO_FUNCTION(dba) { dba_handler *hptr; - static char handlers[80], tmp[5]; + smart_str handlers = {0}; for(hptr = handler; hptr->name; hptr++) { - sprintf(tmp, "%s ", hptr->name); - strcat(handlers, tmp); + smart_str_appends(&handlers, hptr->name); + smart_str_appendc(&handlers, ' '); } php_info_print_table_start(); php_info_print_table_row(2, "DBA support", "enabled"); - php_info_print_table_row(2, "Supported handlers", handlers); + php_info_print_table_row(2, "Supported handlers", handlers.c); php_info_print_table_end(); + smart_str_free(&handlers); } -- 2.50.1