From 8455cfedfa7ce4f59f3ba0605cba6ae57aa292a6 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 21 Jan 2019 18:59:11 +0000 Subject: [PATCH] gn build: Stop passing -DLLVM_LIBXML2_ENABLED to some targets This is a remnant from before the gn build had a working config.h. Defining LLVM_LIBXML2_ENABLED only for targets that depend on build/libs/xml is nice in that only some of the codebase needs to be rebuilt when llvm_enable_libxml2 changes -- but config.h already defines it and defining it there and then redundantly a second time for some targets is worse than having it just in config.h. No behavior change. Differential Revision: https://reviews.llvm.org/D56908 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351758 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/gn/build/libs/xml/BUILD.gn | 1 - 1 file changed, 1 deletion(-) diff --git a/utils/gn/build/libs/xml/BUILD.gn b/utils/gn/build/libs/xml/BUILD.gn index f3590f4601c..3af3c851698 100644 --- a/utils/gn/build/libs/xml/BUILD.gn +++ b/utils/gn/build/libs/xml/BUILD.gn @@ -3,7 +3,6 @@ import("//llvm/utils/gn/build/mac_sdk.gni") config("xml_config") { visibility = [ ":xml" ] - defines = [ "LLVM_LIBXML2_ENABLED" ] libs = [ "xml2" ] if (host_os == "mac") { include_dirs = [ "$mac_sdk_path/usr/include/libxml2" ] -- 2.50.1