From 841a7a98fc4623e0bcecfa393e7818ade4198a15 Mon Sep 17 00:00:00 2001 From: Tomohiro Kusumi Date: Sun, 26 May 2019 06:29:10 +0900 Subject: [PATCH] Update descriptions for vnops These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov Reviewed-by: Brian Behlendorf Signed-off-by: Tomohiro Kusumi Closes #8767 --- module/zfs/zfs_vnops.c | 20 +++++++++++--------- module/zfs/zfs_znode.c | 7 +++---- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/module/zfs/zfs_vnops.c b/module/zfs/zfs_vnops.c index 885d9633b..9d8a9cbc5 100644 --- a/module/zfs/zfs_vnops.c +++ b/module/zfs/zfs_vnops.c @@ -1676,6 +1676,7 @@ out: * IN: dip - inode of directory to remove entry from. * name - name of entry to remove. * cr - credentials of caller. + * flags - case flags. * * RETURN: 0 if success * error code if failure @@ -1917,6 +1918,7 @@ out: * dirname - name of new directory. * vap - attributes of new directory. * cr - credentials of caller. + * flags - case flags. * vsecp - ACL to be set * * OUT: ipp - inode of created directory. @@ -2235,13 +2237,12 @@ out: } /* - * Read as many directory entries as will fit into the provided - * dirent buffer from the given directory cursor position. + * Read directory entries from the given directory cursor position and emit + * name and position for each entry. * * IN: ip - inode of directory to read. - * dirent - buffer for directory entries. - * - * OUT: dirent - filler buffer of directory entries. + * ctx - directory entry context. + * cr - credentials of caller. * * RETURN: 0 if success * error code if failure @@ -4006,13 +4007,14 @@ out: * Insert the indicated symbolic reference entry into the directory. * * IN: dip - Directory to contain new symbolic link. - * link - Name for new symlink entry. + * name - Name of directory entry in dip. * vap - Attributes of new entry. - * target - Target path of new symlink. - * + * link - Name for new symlink entry. * cr - credentials of caller. * flags - case flags * + * OUT: ipp - Inode for new symbolic link. + * * RETURN: 0 on success, error code on failure. * * Timestamps: @@ -4216,6 +4218,7 @@ zfs_readlink(struct inode *ip, uio_t *uio, cred_t *cr) * sip - inode of new entry. * name - name of new entry. * cr - credentials of caller. + * flags - case flags. * * RETURN: 0 if success * error code if failure @@ -4729,7 +4732,6 @@ zfs_inactive(struct inode *ip) * IN: ip - inode seeking within * ooff - old file offset * noffp - pointer to new file offset - * ct - caller context * * RETURN: 0 if success * EINVAL if new offset invalid diff --git a/module/zfs/zfs_znode.c b/module/zfs/zfs_znode.c index 77eb8bb91..203a59909 100644 --- a/module/zfs/zfs_znode.c +++ b/module/zfs/zfs_znode.c @@ -651,12 +651,11 @@ static zfs_acl_phys_t acl_phys; * cr - credentials of caller * flag - flags: * IS_ROOT_NODE - new object will be root + * IS_TMPFILE - new object is of O_TMPFILE * IS_XATTR - new object is an attribute - * bonuslen - length of bonus buffer - * setaclp - File/Dir initial ACL - * fuidp - Tracks fuid allocation. + * acl_ids - ACL related attributes * - * OUT: zpp - allocated znode + * OUT: zpp - allocated znode (set to dzp if IS_ROOT_NODE) * */ void -- 2.40.0