From 841259051ac711eda2c002ea5414ffcb3eaf8cec Mon Sep 17 00:00:00 2001 From: Serge Pavlov Date: Wed, 25 Jan 2017 07:58:10 +0000 Subject: [PATCH] Do not verify dominator tree if it has no roots If dominator tree has no roots, the pass that calculates it is likely to be skipped. It occures, for instance, in the case of entities with linkage available_externally. Do not run tree verification in such case. Differential Revision: https://reviews.llvm.org/D28767 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@293033 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/MachineDominators.cpp | 4 ++++ lib/IR/Dominators.cpp | 4 ++++ test/CodeGen/Generic/externally_available.ll | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/CodeGen/MachineDominators.cpp b/lib/CodeGen/MachineDominators.cpp index 303a6a9263b..4e348877697 100644 --- a/lib/CodeGen/MachineDominators.cpp +++ b/lib/CodeGen/MachineDominators.cpp @@ -143,6 +143,10 @@ void MachineDominatorTree::applySplitCriticalEdges() const { } void MachineDominatorTree::verifyDomTree() const { + if (getRoots().empty()) + // If dominator tree is unavailable, skip verification. + return; + MachineFunction &F = *getRoot()->getParent(); MachineDominatorTree OtherDT; diff --git a/lib/IR/Dominators.cpp b/lib/IR/Dominators.cpp index 44948cc5831..392670bbd29 100644 --- a/lib/IR/Dominators.cpp +++ b/lib/IR/Dominators.cpp @@ -291,6 +291,10 @@ bool DominatorTree::isReachableFromEntry(const Use &U) const { } void DominatorTree::verifyDomTree() const { + if (getRoots().empty()) + // If dominator tree is unavailable, skip verification. + return; + Function &F = *getRoot()->getParent(); DominatorTree OtherDT; diff --git a/test/CodeGen/Generic/externally_available.ll b/test/CodeGen/Generic/externally_available.ll index 7976cc97188..2376bc73992 100644 --- a/test/CodeGen/Generic/externally_available.ll +++ b/test/CodeGen/Generic/externally_available.ll @@ -1,4 +1,4 @@ -; RUN: llc < %s | not grep test_ +; RUN: llc -verify-machine-dom-info < %s | not grep test_ ; test_function should not be emitted to the .s file. define available_externally i32 @test_function() { -- 2.40.0