From 83baf5e232e620afc5747e7880df7b848de12bbb Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Fri, 29 Mar 2019 17:51:39 +0000 Subject: [PATCH] [InstCombine] autogenerate complete checks; NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@357291 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../InstCombine/phi-select-constant.ll | 81 ++++++++++++------- 1 file changed, 50 insertions(+), 31 deletions(-) diff --git a/test/Transforms/InstCombine/phi-select-constant.ll b/test/Transforms/InstCombine/phi-select-constant.ll index 2b0bf434265..bc2f9ac202b 100644 --- a/test/Transforms/InstCombine/phi-select-constant.ll +++ b/test/Transforms/InstCombine/phi-select-constant.ll @@ -1,17 +1,24 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; RUN: opt < %s -S -instcombine | FileCheck %s @A = extern_weak global i32, align 4 @B = extern_weak global i32, align 4 define i32 @foo(i1 %which) { +; CHECK-LABEL: @foo( +; CHECK-NEXT: entry: +; CHECK-NEXT: br i1 [[WHICH:%.*]], label [[FINAL:%.*]], label [[DELAY:%.*]] +; CHECK: delay: +; CHECK-NEXT: br label [[FINAL]] +; CHECK: final: +; CHECK-NEXT: [[USE2:%.*]] = phi i32 [ 1, [[ENTRY:%.*]] ], [ select (i1 icmp eq (i32* @A, i32* @B), i32 2, i32 1), [[DELAY]] ] +; CHECK-NEXT: ret i32 [[USE2]] +; entry: br i1 %which, label %final, label %delay delay: br label %final -; CHECK-LABEL: @foo -; CHECK-LABEL: final: -; CHECK: phi i32 [ 1, %entry ], [ select (i1 icmp eq (i32* @A, i32* @B), i32 2, i32 1), %delay ] final: %use2 = phi i1 [ false, %entry ], [ icmp eq (i32* @A, i32* @B), %delay ] %value = select i1 %use2, i32 2, i32 1 @@ -21,64 +28,76 @@ final: ; test folding of select into phi for vectors. define <4 x i64> @vec1(i1 %which) { +; CHECK-LABEL: @vec1( +; CHECK-NEXT: entry: +; CHECK-NEXT: br i1 [[WHICH:%.*]], label [[FINAL:%.*]], label [[DELAY:%.*]] +; CHECK: delay: +; CHECK-NEXT: br label [[FINAL]] +; CHECK: final: +; CHECK-NEXT: [[PHINODE:%.*]] = phi <4 x i64> [ zeroinitializer, [[ENTRY:%.*]] ], [ , [[DELAY]] ] +; CHECK-NEXT: ret <4 x i64> [[PHINODE]] +; entry: br i1 %which, label %final, label %delay delay: - br label %final + br label %final final: -; CHECK-LABEL: @vec1 -; CHECK-LABEL: final: -; CHECK: %phinode = phi <4 x i64> [ zeroinitializer, %entry ], [ , %delay ] -; CHECK-NOT: select -; CHECK: ret <4 x i64> %phinode - %phinode = phi <4 x i1> [ , %entry ], [ , %delay ] - %sel = select <4 x i1> %phinode, <4 x i64> zeroinitializer, <4 x i64> - ret <4 x i64> %sel + %phinode = phi <4 x i1> [ , %entry ], [ , %delay ] + %sel = select <4 x i1> %phinode, <4 x i64> zeroinitializer, <4 x i64> + ret <4 x i64> %sel } define <4 x i64> @vec2(i1 %which) { +; CHECK-LABEL: @vec2( +; CHECK-NEXT: entry: +; CHECK-NEXT: br i1 [[WHICH:%.*]], label [[FINAL:%.*]], label [[DELAY:%.*]] +; CHECK: delay: +; CHECK-NEXT: br label [[FINAL]] +; CHECK: final: +; CHECK-NEXT: [[PHINODE:%.*]] = phi <4 x i64> [ , [[ENTRY:%.*]] ], [ , [[DELAY]] ] +; CHECK-NEXT: ret <4 x i64> [[PHINODE]] +; entry: br i1 %which, label %final, label %delay delay: - br label %final + br label %final final: -; CHECK-LABEL: @vec2 -; CHECK-LABEL: final: -; CHECK: %phinode = phi <4 x i64> [ , %entry ], [ , %delay ] -; CHECK-NOT: select -; CHECK: ret <4 x i64> %phinode - %phinode = phi <4 x i1> [ , %entry ], [ , %delay ] - %sel = select <4 x i1> %phinode, <4 x i64> zeroinitializer, <4 x i64> - ret <4 x i64> %sel + %phinode = phi <4 x i1> [ , %entry ], [ , %delay ] + %sel = select <4 x i1> %phinode, <4 x i64> zeroinitializer, <4 x i64> + ret <4 x i64> %sel } ; Test PR33364 ; Insert the generated select into the same block as the incoming phi value. ; phi has constant vectors along with a single non-constant vector as operands. define <2 x i8> @vec3(i1 %cond1, i1 %cond2, <2 x i1> %x, <2 x i8> %y, <2 x i8> %z) { -; CHECK-LABEL: @vec3 -; CHECK: entry: -; CHECK-NEXT: [[PHITMP1:%.*]] = shufflevector <2 x i8> %y, <2 x i8> %z, <2 x i32> +; CHECK-LABEL: @vec3( +; CHECK-NEXT: entry: +; CHECK-NEXT: [[PHITMP1:%.*]] = shufflevector <2 x i8> [[Y:%.*]], <2 x i8> [[Z:%.*]], <2 x i32> +; CHECK-NEXT: br i1 [[COND1:%.*]], label [[IF1:%.*]], label [[ELSE:%.*]] +; CHECK: if1: +; CHECK-NEXT: [[PHITMP2:%.*]] = shufflevector <2 x i8> [[Y]], <2 x i8> [[Z]], <2 x i32> +; CHECK-NEXT: br i1 [[COND2:%.*]], label [[IF2:%.*]], label [[ELSE]] +; CHECK: if2: +; CHECK-NEXT: [[PHITMP:%.*]] = select <2 x i1> [[X:%.*]], <2 x i8> [[Y]], <2 x i8> [[Z]] +; CHECK-NEXT: br label [[ELSE]] +; CHECK: else: +; CHECK-NEXT: [[PHI:%.*]] = phi <2 x i8> [ [[PHITMP]], [[IF2]] ], [ [[PHITMP1]], [[ENTRY:%.*]] ], [ [[PHITMP2]], [[IF1]] ] +; CHECK-NEXT: ret <2 x i8> [[PHI]] +; entry: br i1 %cond1, label %if1, label %else -; CHECK: if1: -; CHECK-NEXT: [[PHITMP2:%.*]] = shufflevector <2 x i8> %y, <2 x i8> %z, <2 x i32> if1: br i1 %cond2, label %if2, label %else -; CHECK: if2: -; CHECK-NEXT: [[PHITMP3:%.*]] = select <2 x i1> %x, <2 x i8> %y, <2 x i8> %z if2: br label %else -; CHECK: else: -; CHECK-NEXT: [[PHITMP4:%.*]] = phi <2 x i8> [ [[PHITMP3]], %if2 ], [ [[PHITMP1]], %entry ], [ [[PHITMP2]], %if1 ] -; CHECK-NEXT: ret <2 x i8> [[PHITMP4]] else: %phi = phi <2 x i1> [ %x, %if2 ], [ , %entry ], [ , %if1 ] %sel = select <2 x i1> %phi, <2 x i8> %y, <2 x i8> %z -- 2.40.0