From 83af88427f94a5788020b09460c90dcd13e122fb Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Mon, 18 Sep 2017 21:57:56 +0000 Subject: [PATCH] [InstCombine] auto-generate complete checks; NFC The code responsible for these transforms has the potential to add 2 instructions and break min/max patterns (PR33301). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@313575 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../InstCombine/select-extractelement.ll | 71 ++++++++++++++++--- 1 file changed, 62 insertions(+), 9 deletions(-) diff --git a/test/Transforms/InstCombine/select-extractelement.ll b/test/Transforms/InstCombine/select-extractelement.ll index e7ea851d921..10ce220346b 100644 --- a/test/Transforms/InstCombine/select-extractelement.ll +++ b/test/Transforms/InstCombine/select-extractelement.ll @@ -2,11 +2,14 @@ declare void @v4float_user(<4 x float>) #0 - - define float @extract_one_select(<4 x float> %a, <4 x float> %b, i32 %c) #0 { ; CHECK-LABEL: @extract_one_select( -; CHECK-NOT: select i1 {{.*}}, <4 x float> +; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 %c, 0 +; CHECK-NEXT: [[B_ELT:%.*]] = extractelement <4 x float> %b, i32 2 +; CHECK-NEXT: [[A_ELT:%.*]] = extractelement <4 x float> %a, i32 2 +; CHECK-NEXT: [[EXTRACT:%.*]] = select i1 [[CMP]], float [[B_ELT]], float [[A_ELT]] +; CHECK-NEXT: ret float [[EXTRACT]] +; %cmp = icmp ne i32 %c, 0 %sel = select i1 %cmp, <4 x float> %a, <4 x float> %b %extract = extractelement <4 x float> %sel, i32 2 @@ -16,7 +19,11 @@ define float @extract_one_select(<4 x float> %a, <4 x float> %b, i32 %c) #0 { ; Multiple extractelements define <2 x float> @extract_two_select(<4 x float> %a, <4 x float> %b, i32 %c) #0 { ; CHECK-LABEL: @extract_two_select( -; CHECK: select i1 {{.*}}, <4 x float> +; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 %c, 0 +; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], <4 x float> %b, <4 x float> %a +; CHECK-NEXT: [[BUILD2:%.*]] = shufflevector <4 x float> [[SEL]], <4 x float> undef, <2 x i32> +; CHECK-NEXT: ret <2 x float> [[BUILD2]] +; %cmp = icmp ne i32 %c, 0 %sel = select i1 %cmp, <4 x float> %a, <4 x float> %b %extract1 = extractelement <4 x float> %sel, i32 1 @@ -29,7 +36,12 @@ define <2 x float> @extract_two_select(<4 x float> %a, <4 x float> %b, i32 %c) # ; Select has an extra non-extractelement user, don't change it define float @extract_one_select_user(<4 x float> %a, <4 x float> %b, i32 %c) #0 { ; CHECK-LABEL: @extract_one_select_user( -; CHECK: select i1 {{.*}}, <4 x float> +; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 %c, 0 +; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], <4 x float> %b, <4 x float> %a +; CHECK-NEXT: [[EXTRACT:%.*]] = extractelement <4 x float> [[SEL]], i32 2 +; CHECK-NEXT: call void @v4float_user(<4 x float> [[SEL]]) +; CHECK-NEXT: ret float [[EXTRACT]] +; %cmp = icmp ne i32 %c, 0 %sel = select i1 %cmp, <4 x float> %a, <4 x float> %b %extract = extractelement <4 x float> %sel, i32 2 @@ -39,7 +51,12 @@ define float @extract_one_select_user(<4 x float> %a, <4 x float> %b, i32 %c) #0 define float @extract_one_vselect_user(<4 x float> %a, <4 x float> %b, <4 x i32> %c) #0 { ; CHECK-LABEL: @extract_one_vselect_user( -; CHECK: select <4 x i1> {{.*}}, <4 x float> +; CHECK-NEXT: [[CMP:%.*]] = icmp eq <4 x i32> %c, zeroinitializer +; CHECK-NEXT: [[SEL:%.*]] = select <4 x i1> [[CMP]], <4 x float> %b, <4 x float> %a +; CHECK-NEXT: [[EXTRACT:%.*]] = extractelement <4 x float> [[SEL]], i32 2 +; CHECK-NEXT: call void @v4float_user(<4 x float> [[SEL]]) +; CHECK-NEXT: ret float [[EXTRACT]] +; %cmp = icmp ne <4 x i32> %c, zeroinitializer %sel = select <4 x i1> %cmp, <4 x float> %a, <4 x float> %b %extract = extractelement <4 x float> %sel, i32 2 @@ -50,7 +67,13 @@ define float @extract_one_vselect_user(<4 x float> %a, <4 x float> %b, <4 x i32> ; Extract from a vector select define float @extract_one_vselect(<4 x float> %a, <4 x float> %b, <4 x i32> %c) #0 { ; CHECK-LABEL: @extract_one_vselect( -; CHECK-NOT: select <4 x i1> +; CHECK-NEXT: [[CMP:%.*]] = icmp eq <4 x i32> %c, zeroinitializer +; CHECK-NEXT: [[CMP_ELT:%.*]] = extractelement <4 x i1> [[CMP]], i32 0 +; CHECK-NEXT: [[B_ELT:%.*]] = extractelement <4 x float> %b, i32 0 +; CHECK-NEXT: [[A_ELT:%.*]] = extractelement <4 x float> %a, i32 0 +; CHECK-NEXT: [[EXTRACT:%.*]] = select i1 [[CMP_ELT]], float [[B_ELT]], float [[A_ELT]] +; CHECK-NEXT: ret float [[EXTRACT]] +; %cmp = icmp ne <4 x i32> %c, zeroinitializer %select = select <4 x i1> %cmp, <4 x float> %a, <4 x float> %b %extract = extractelement <4 x float> %select, i32 0 @@ -60,7 +83,11 @@ define float @extract_one_vselect(<4 x float> %a, <4 x float> %b, <4 x i32> %c) ; Multiple extractelements from a vector select define <2 x float> @extract_two_vselect(<4 x float> %a, <4 x float> %b, <4 x i32> %c) #0 { ; CHECK-LABEL: @extract_two_vselect( -; CHECK-NOT: select i1 {{.*}}, <4 x float> +; CHECK-NEXT: [[CMP:%.*]] = icmp eq <4 x i32> %c, zeroinitializer +; CHECK-NEXT: [[SEL:%.*]] = select <4 x i1> [[CMP]], <4 x float> %b, <4 x float> %a +; CHECK-NEXT: [[BUILD2:%.*]] = shufflevector <4 x float> [[SEL]], <4 x float> undef, <2 x i32> +; CHECK-NEXT: ret <2 x float> [[BUILD2]] +; %cmp = icmp ne <4 x i32> %c, zeroinitializer %sel = select <4 x i1> %cmp, <4 x float> %a, <4 x float> %b %extract1 = extractelement <4 x float> %sel, i32 1 @@ -74,7 +101,33 @@ define <2 x float> @extract_two_vselect(<4 x float> %a, <4 x float> %b, <4 x i32 ; Test multiple extractelements define <4 x float> @simple_vector_select(<4 x float> %a, <4 x float> %b, <4 x i32> %c) #0 { ; CHECK-LABEL: @simple_vector_select( -; CHECK-NOT: select i1 {{.*}}, <4 x float> +; CHECK-NEXT: entry: +; CHECK-NEXT: [[TMP0:%.*]] = extractelement <4 x i32> %c, i32 0 +; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[TMP0]], 0 +; CHECK-NEXT: [[B_ELT:%.*]] = extractelement <4 x float> %b, i32 0 +; CHECK-NEXT: [[A_ELT:%.*]] = extractelement <4 x float> %a, i32 0 +; CHECK-NEXT: [[TMP1:%.*]] = select i1 [[TOBOOL]], float [[B_ELT]], float [[A_ELT]] +; CHECK-NEXT: [[TMP2:%.*]] = insertelement <4 x float> undef, float [[TMP1]], i32 0 +; CHECK-NEXT: [[TMP3:%.*]] = extractelement <4 x i32> %c, i32 1 +; CHECK-NEXT: [[TOBOOL1:%.*]] = icmp eq i32 [[TMP3]], 0 +; CHECK-NEXT: [[B_ELT1:%.*]] = extractelement <4 x float> %b, i32 1 +; CHECK-NEXT: [[A_ELT2:%.*]] = extractelement <4 x float> %a, i32 1 +; CHECK-NEXT: [[TMP4:%.*]] = select i1 [[TOBOOL1]], float [[B_ELT1]], float [[A_ELT2]] +; CHECK-NEXT: [[TMP5:%.*]] = insertelement <4 x float> [[TMP2]], float [[TMP4]], i32 1 +; CHECK-NEXT: [[TMP6:%.*]] = extractelement <4 x i32> %c, i32 2 +; CHECK-NEXT: [[TOBOOL6:%.*]] = icmp eq i32 [[TMP6]], 0 +; CHECK-NEXT: [[B_ELT3:%.*]] = extractelement <4 x float> %b, i32 2 +; CHECK-NEXT: [[A_ELT4:%.*]] = extractelement <4 x float> %a, i32 2 +; CHECK-NEXT: [[TMP7:%.*]] = select i1 [[TOBOOL6]], float [[B_ELT3]], float [[A_ELT4]] +; CHECK-NEXT: [[TMP8:%.*]] = insertelement <4 x float> [[TMP5]], float [[TMP7]], i32 2 +; CHECK-NEXT: [[TMP9:%.*]] = extractelement <4 x i32> %c, i32 3 +; CHECK-NEXT: [[TOBOOL11:%.*]] = icmp eq i32 [[TMP9]], 0 +; CHECK-NEXT: [[B_ELT5:%.*]] = extractelement <4 x float> %b, i32 3 +; CHECK-NEXT: [[A_ELT6:%.*]] = extractelement <4 x float> %a, i32 3 +; CHECK-NEXT: [[TMP10:%.*]] = select i1 [[TOBOOL11]], float [[B_ELT5]], float [[A_ELT6]] +; CHECK-NEXT: [[TMP11:%.*]] = insertelement <4 x float> [[TMP8]], float [[TMP10]], i32 3 +; CHECK-NEXT: ret <4 x float> [[TMP11]] +; entry: %0 = extractelement <4 x i32> %c, i32 0 %tobool = icmp ne i32 %0, 0 -- 2.40.0