From 829ce1e218ca9ea4a7b9350cd72e48d8f9771d72 Mon Sep 17 00:00:00 2001
From: brarcher <brarcher@64e312b2-a51f-0410-8e61-82d0ca0eb02a>
Date: Sun, 4 Nov 2012 03:24:27 +0000
Subject: [PATCH] silence warning regarding ignoring pipe's return value

Check's unit tests were calling pipe but ignore its return value.
This results in a compiler warning. The offending unit tests now
check the return value and call ck_assert_msg with it.


git-svn-id: svn+ssh://svn.code.sf.net/p/check/code/trunk@650 64e312b2-a51f-0410-8e61-82d0ca0eb02a
---
 tests/check_check_pack.c | 32 ++++++++++++++++++++++----------
 1 file changed, 22 insertions(+), 10 deletions(-)

diff --git a/tests/check_check_pack.c b/tests/check_check_pack.c
index 4dc7a2a..c703de0 100644
--- a/tests/check_check_pack.c
+++ b/tests/check_check_pack.c
@@ -197,12 +197,14 @@ START_TEST(test_ppack)
   LocMsg lmsg;
   FailMsg fmsg;
   RcvMsg *rmsg;
-
+  int pipe_result;
+  
   cmsg.ctx = CK_CTX_TEST;
   lmsg.file = (char *) "abc123.c";
   lmsg.line = 10;
   fmsg.msg = (char *) "oops";
-  pipe (filedes);
+  pipe_result = pipe (filedes);
+  ck_assert_msg (pipe_result == 0, "Failed to create pipe");
   ppack (filedes[1], CK_MSG_CTX, (CheckMsg *) &cmsg);
   ppack (filedes[1], CK_MSG_LOC, (CheckMsg *) &lmsg);
   ppack (filedes[1], CK_MSG_FAIL, (CheckMsg *) &fmsg);
@@ -234,11 +236,13 @@ START_TEST(test_ppack_noctx)
   LocMsg lmsg;
   FailMsg fmsg;
   RcvMsg *rmsg;
-
+  int pipe_result;
+  
   lmsg.file = (char *) "abc123.c";
   lmsg.line = 10;
   fmsg.msg = (char *) "oops";
-  pipe (filedes);
+  pipe_result = pipe (filedes);
+  ck_assert_msg (pipe_result == 0, "Failed to create pipe");
   ppack (filedes[1], CK_MSG_LOC, (CheckMsg *) &lmsg);
   ppack (filedes[1], CK_MSG_FAIL, (CheckMsg *) &fmsg);
   close (filedes[1]);
@@ -257,9 +261,11 @@ START_TEST(test_ppack_onlyctx)
   int filedes[2];
   CtxMsg cmsg;
   RcvMsg *rmsg;
-
+  int pipe_result;
+  
   cmsg.ctx = CK_CTX_SETUP;
-  pipe (filedes);
+  pipe_result = pipe (filedes);
+  ck_assert_msg (pipe_result == 0, "Failed to create pipe");
   ppack (filedes[1], CK_MSG_CTX, (CheckMsg *) &cmsg);
   close (filedes[1]);
   rmsg = punpack (filedes[0]);
@@ -282,11 +288,13 @@ START_TEST(test_ppack_multictx)
   CtxMsg cmsg;
   LocMsg lmsg;
   RcvMsg *rmsg;
-
+  int pipe_result;
+  
   cmsg.ctx = CK_CTX_SETUP;
   lmsg.line = 5;
   lmsg.file = (char *) "abc123.c";
-  pipe (filedes);
+  pipe_result = pipe (filedes);
+  ck_assert_msg (pipe_result == 0, "Failed to create pipe");
   ppack (filedes[1], CK_MSG_CTX, (CheckMsg *) &cmsg);
   ppack (filedes[1], CK_MSG_LOC, (CheckMsg *) &lmsg);
   cmsg.ctx = CK_CTX_TEST;
@@ -313,11 +321,13 @@ START_TEST(test_ppack_nofail)
   CtxMsg cmsg;
   LocMsg lmsg;
   RcvMsg *rmsg;
+  int pipe_result;
 
   lmsg.file = (char *) "abc123.c";
   lmsg.line = 10;
   cmsg.ctx = CK_CTX_SETUP;
-  pipe (filedes);
+  pipe_result = pipe (filedes);
+  ck_assert_msg (pipe_result == 0, "Failed to create pipe");
   ppack (filedes[1], CK_MSG_CTX, (CheckMsg *) &cmsg);
   ppack (filedes[1], CK_MSG_LOC, (CheckMsg *) &lmsg);
   close (filedes[1]);
@@ -339,6 +349,7 @@ START_TEST(test_ppack_big)
   LocMsg lmsg;
   FailMsg fmsg;
   RcvMsg *rmsg;
+  int pipe_result;
 
   cmsg.ctx = CK_CTX_TEST;
   lmsg.file = emalloc (BIG_MSG_LEN);
@@ -348,7 +359,8 @@ START_TEST(test_ppack_big)
   fmsg.msg = emalloc (BIG_MSG_LEN);
   memset (fmsg.msg, 'a', BIG_MSG_LEN - 1);
   fmsg.msg[BIG_MSG_LEN - 1] = '\0';
-  pipe (filedes);
+  pipe_result = pipe (filedes);
+  ck_assert_msg (pipe_result == 0, "Failed to create pipe");
   ppack (filedes[1], CK_MSG_CTX, (CheckMsg *) &cmsg);
   ppack (filedes[1], CK_MSG_LOC, (CheckMsg *) &lmsg);
   ppack (filedes[1], CK_MSG_FAIL, (CheckMsg *) &fmsg);
-- 
2.40.0