From 8258845b81b220c1b41a0711c491768f82b10e2e Mon Sep 17 00:00:00 2001 From: Alp Toker Date: Sat, 7 Jun 2014 23:31:01 +0000 Subject: [PATCH] DeclObjC: Fix comments about bad API What's going on here isn't overriding but rather the sketchy practice of member hiding (shadowing of base members). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@210404 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/AST/DeclObjC.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/clang/AST/DeclObjC.h b/include/clang/AST/DeclObjC.h index 44d85b53b5..520f523a6d 100644 --- a/include/clang/AST/DeclObjC.h +++ b/include/clang/AST/DeclObjC.h @@ -1927,8 +1927,8 @@ public: /// getIdentifier - Get the identifier that names the category /// interface associated with this implementation. - /// FIXME: This is a bad API, we are overriding the NamedDecl::getIdentifier() - /// to mean something different. For example: + /// FIXME: This is a bad API, we are hiding NamedDecl::getIdentifier() + /// with a different meaning. For example: /// ((NamedDecl *)SomeCategoryImplDecl)->getIdentifier() /// returns the class interface name, whereas /// ((ObjCCategoryImplDecl *)SomeCategoryImplDecl)->getIdentifier() @@ -1945,8 +1945,8 @@ public: /// getName - Get the name of identifier for the class interface associated /// with this implementation as a StringRef. // - // FIXME: This is a bad API, we are overriding the NamedDecl::getName, to mean - // something different. + // FIXME: This is a bad API, we are hiding NamedDecl::getName with a different + // meaning. StringRef getName() const { return Id ? Id->getName() : StringRef(); } /// @brief Get the name of the class associated with this interface. @@ -2087,8 +2087,8 @@ public: /// getName - Get the name of identifier for the class interface associated /// with this implementation as a StringRef. // - // FIXME: This is a bad API, we are overriding the NamedDecl::getName, to mean - // something different. + // FIXME: This is a bad API, we are hiding NamedDecl::getName with a different + // meaning. StringRef getName() const { assert(getIdentifier() && "Name is not a simple identifier"); return getIdentifier()->getName(); -- 2.50.1