From 813f1b8a37bc1384b33d6598ec5bad0c8e754caf Mon Sep 17 00:00:00 2001
From: Christos Zoulas <christos@zoulas.com>
Date: Thu, 2 Aug 2018 12:46:02 +0000
Subject: [PATCH] correct error handling for file_printf() (coverity)

---
 src/readelf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/readelf.c b/src/readelf.c
index e9a125f2..71836ca2 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -27,7 +27,7 @@
 #include "file.h"
 
 #ifndef lint
-FILE_RCSID("@(#)$File: readelf.c,v 1.149 2018/08/01 10:09:47 christos Exp $")
+FILE_RCSID("@(#)$File: readelf.c,v 1.150 2018/08/02 12:46:02 christos Exp $")
 #endif
 
 #ifdef BUILTIN_ELF
@@ -565,7 +565,7 @@ do_bid_note(struct magic_set *ms, unsigned char *nbuf, uint32_t type,
 	    type == NT_GO_BUILD_ID && descsz < 128) {
 		if (file_printf(ms, ", Go BuildID=%s",
 		    (char *)&nbuf[doff]) == -1)
-			return 1;
+			return -1;
 		return 1;
 	}
 	return 0;
@@ -1118,14 +1118,16 @@ donote(struct magic_set *ms, void *vbuf, size_t offset, size_t size,
 	}
 
 	if (namesz & 0x80000000) {
-	    file_printf(ms, ", bad note name size %#lx",
-		CAST(unsigned long, namesz));
+		if (((file_printf(ms, ", bad note name size %#lx",
+		    CAST(unsigned long, namesz)) == -1)
+			return -1;
 	    return 0;
 	}
 
 	if (descsz & 0x80000000) {
-	    file_printf(ms, ", bad note description size %#lx",
-		CAST(unsigned long, descsz));
+		if (file_printf(ms, ", bad note description size %#lx",
+		    CAST(unsigned long, descsz)) == -1)
+		    	return -1;
 	    return 0;
 	}
 
-- 
2.49.0