From 7fb6f5121a42136f35c561c408091cd043f6340d Mon Sep 17 00:00:00 2001 From: Ronald Oussoren Date: Sun, 1 Aug 2010 19:18:13 +0000 Subject: [PATCH] test_getgroups as introduced with issue7900 failed on systems where 'id -G' and posix.getgroups() returned the same information, but one of the sources contains duplicate information. Rewrite the check using sets instead of lists. --- Lib/test/test_posix.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py index b6322b4137..a22ebdf7c7 100644 --- a/Lib/test/test_posix.py +++ b/Lib/test/test_posix.py @@ -357,11 +357,11 @@ class PosixTester(unittest.TestCase): if not groups: raise unittest.SkipTest("need working 'id -G'") - # The order of groups isn't important, hence the calls - # to sorted. + # 'id -G' and 'os.getgroups()' should return the same + # groups, ignoring order and duplicates. self.assertEqual( - list(sorted([int(x) for x in groups.split()])), - list(sorted(posix.getgroups()))) + set([int(x) for x in groups.split()]), + set(posix.getgroups())) class PosixGroupsTester(unittest.TestCase): -- 2.40.0