From 7f47814c4e7f573df27ed7bdd13da75deaa84dc1 Mon Sep 17 00:00:00 2001 From: Nuno Lopes Date: Sun, 24 Jun 2007 11:41:12 +0000 Subject: [PATCH] fix memleak in sxe_prop_dim_read() #found by coverity --- ext/simplexml/simplexml.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c index 9000ac5892..a62151d884 100644 --- a/ext/simplexml/simplexml.c +++ b/ext/simplexml/simplexml.c @@ -271,9 +271,6 @@ static zval * sxe_prop_dim_read(zval *object, zval *member, zend_bool elements, name = Z_STRVAL_P(member); } - MAKE_STD_ZVAL(return_value); - ZVAL_NULL(return_value); - GET_NODE(sxe, node); if (sxe->iter.type == SXE_ITER_ATTRLIST) { @@ -294,6 +291,9 @@ static zval * sxe_prop_dim_read(zval *object, zval *member, zend_bool elements, } } + MAKE_STD_ZVAL(return_value); + ZVAL_NULL(return_value); + if (node) { if (attribs) { if (Z_TYPE_P(member) != IS_LONG || sxe->iter.type == SXE_ITER_ATTRLIST) { -- 2.50.1