From 7f0d3f7d70e3fd2fa08d25e5b977bf16aced09d0 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Fri, 5 Nov 2010 05:28:07 +0000 Subject: [PATCH] Fix bug #53226 (file_exists fails on big filenames). --- main/fopen_wrappers.c | 8 ++++++++ tests/security/bug53226.phpt | 31 +++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 tests/security/bug53226.phpt diff --git a/main/fopen_wrappers.c b/main/fopen_wrappers.c index f8679d5675..5424f78970 100644 --- a/main/fopen_wrappers.c +++ b/main/fopen_wrappers.c @@ -291,6 +291,14 @@ PHPAPI int php_check_open_basedir_ex(const char *path, int warn TSRMLS_DC) char *ptr; char *end; + /* Check if the path is too long so we can give a more useful error + * message. */ + if (strlen(path) > (MAXPATHLEN - 1)) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "File name is longer than the maximum allowed path length on this platform (%d): %s", MAXPATHLEN, path); + errno = EINVAL; + return -1; + } + pathbuf = estrdup(PG(open_basedir)); ptr = pathbuf; diff --git a/tests/security/bug53226.phpt b/tests/security/bug53226.phpt new file mode 100644 index 0000000000..e462d3e9d7 --- /dev/null +++ b/tests/security/bug53226.phpt @@ -0,0 +1,31 @@ +--TEST-- +Bug #53226 (file_exists fails on big filenames) +--INI-- +open_basedir=. +--FILE-- + +--CLEAN-- + +--EXPECTF-- +bool(true) +bool(true) +bool(true) +bool(true) +bool(false) + +Warning: file_exists(): File name is longer than the maximum allowed path length on this platform (%d): %s in %s on line %d +bool(false) -- 2.40.0