From 7d80f210a637693ed1994732b307ceb36a0b9992 Mon Sep 17 00:00:00 2001 From: Sanjoy Das Date: Thu, 16 Jun 2016 21:00:57 +0000 Subject: [PATCH] [EarlyCSE] Minor cosmetic NFC changes - Avoid implicit conversion from pointer to bool - Add a comment when passing in a boolean value git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@272955 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/EarlyCSE.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Transforms/Scalar/EarlyCSE.cpp b/lib/Transforms/Scalar/EarlyCSE.cpp index 48253f62634..0e93b0a37b0 100644 --- a/lib/Transforms/Scalar/EarlyCSE.cpp +++ b/lib/Transforms/Scalar/EarlyCSE.cpp @@ -434,7 +434,7 @@ private: bool isInvariantLoad() const { if (auto *LI = dyn_cast(Inst)) - return LI->getMetadata(LLVMContext::MD_invariant_load); + return LI->getMetadata(LLVMContext::MD_invariant_load) != nullptr; return false; } @@ -763,7 +763,7 @@ bool EarlyCSE::processNode(DomTreeNode *Node) { AvailableLoads.insert( MemInst.getPointerOperand(), LoadValue(Inst, CurrentGeneration, MemInst.getMatchingId(), - MemInst.isAtomic(), false)); + MemInst.isAtomic(), /*IsInvariant=*/false)); // Remember that this was the last unordered store we saw for DSE. We // don't yet handle DSE on ordered or volatile stores since we don't -- 2.50.1