From 7d6977b6f7899bf68577cc0636d6c9fe10a08bdc Mon Sep 17 00:00:00 2001
From: Qualys Security Advisory <qsa@qualys.com>
Date: Thu, 1 Jan 1970 00:00:00 +0000
Subject: [PATCH] skill: Simplify the kill_main() loop.
Right now the "loop=0; break;" is never reached.
---
skill.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/skill.c b/skill.c
index 59c6c765..1a5b3e03 100644
--- a/skill.c
+++ b/skill.c
@@ -419,7 +419,6 @@ static void __attribute__ ((__noreturn__))
kill_main(int argc, char **argv)
{
int signo, i;
- int loop = 1;
long pid;
int exitvalue = EXIT_SUCCESS;
char *sig_option;
@@ -446,7 +445,7 @@ static void __attribute__ ((__noreturn__))
signo = SIGTERM;
opterr=0; /* suppress errors on -123 */
- while (loop == 1 && (i = getopt_long(argc, argv, "l::Ls:hV", longopts, NULL)) != -1)
+ while ((i = getopt_long(argc, argv, "l::Ls:hV", longopts, NULL)) != -1)
switch (i) {
case 'l':
sig_option = NULL;
@@ -491,8 +490,7 @@ static void __attribute__ ((__noreturn__))
exitvalue = EXIT_FAILURE;
exit(exitvalue);
}
- loop=0;
- break;
+ xerrx(EXIT_FAILURE, _("internal error"));
default:
kill_usage(stderr);
}
--
2.40.0