From 7afd3f740fc94be56dda723aa38d0aa937fb1355 Mon Sep 17 00:00:00 2001 From: Charles-Henri Bruyand Date: Wed, 28 Mar 2018 00:44:37 +0200 Subject: [PATCH] rec: prefer references for function parameters --- pdns/dnssecinfra.cc | 2 +- pdns/filterpo.cc | 10 +++++----- pdns/filterpo.hh | 10 +++++----- pdns/ixfr.cc | 2 +- pdns/ixfr.hh | 2 +- pdns/sortlist.hh | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc index 5f662d188..7525eed64 100644 --- a/pdns/dnssecinfra.cc +++ b/pdns/dnssecinfra.cc @@ -460,7 +460,7 @@ DSRecordContent makeDSFromDNSKey(const DNSName& qname, const DNSKEYRecordContent } -static DNSKEYRecordContent makeDNSKEYFromDNSCryptoKeyEngine(const std::shared_ptr pk, uint8_t algorithm, uint16_t flags) +static DNSKEYRecordContent makeDNSKEYFromDNSCryptoKeyEngine(const std::shared_ptr& pk, uint8_t algorithm, uint16_t flags) { DNSKEYRecordContent drc; diff --git a/pdns/filterpo.cc b/pdns/filterpo.cc index c73b202e6..90179584a 100644 --- a/pdns/filterpo.cc +++ b/pdns/filterpo.cc @@ -231,31 +231,31 @@ void DNSFilterEngine::Zone::addNSIPTrigger(const Netmask& nm, Policy pol) d_propolNSAddr.insert(nm).second = pol; } -bool DNSFilterEngine::Zone::rmClientTrigger(const Netmask& nm, Policy pol) +bool DNSFilterEngine::Zone::rmClientTrigger(const Netmask& nm, Policy& pol) { d_qpolAddr.erase(nm); return true; } -bool DNSFilterEngine::Zone::rmResponseTrigger(const Netmask& nm, Policy pol) +bool DNSFilterEngine::Zone::rmResponseTrigger(const Netmask& nm, Policy& pol) { d_postpolAddr.erase(nm); return true; } -bool DNSFilterEngine::Zone::rmQNameTrigger(const DNSName& n, Policy pol) +bool DNSFilterEngine::Zone::rmQNameTrigger(const DNSName& n, Policy& pol) { d_qpolName.erase(n); // XXX verify we had identical policy? return true; } -bool DNSFilterEngine::Zone::rmNSTrigger(const DNSName& n, Policy pol) +bool DNSFilterEngine::Zone::rmNSTrigger(const DNSName& n, Policy& pol) { d_propolName.erase(n); // XXX verify policy matched? =pol; return true; } -bool DNSFilterEngine::Zone::rmNSIPTrigger(const Netmask& nm, Policy pol) +bool DNSFilterEngine::Zone::rmNSIPTrigger(const Netmask& nm, Policy& pol) { d_propolNSAddr.erase(nm); return true; diff --git a/pdns/filterpo.hh b/pdns/filterpo.hh index ba43829b4..f07d37102 100644 --- a/pdns/filterpo.hh +++ b/pdns/filterpo.hh @@ -147,11 +147,11 @@ public: void addNSIPTrigger(const Netmask& nm, Policy pol); void addResponseTrigger(const Netmask& nm, Policy pol); - bool rmClientTrigger(const Netmask& nm, Policy pol); - bool rmQNameTrigger(const DNSName& nm, Policy pol); - bool rmNSTrigger(const DNSName& dn, Policy pol); - bool rmNSIPTrigger(const Netmask& nm, Policy pol); - bool rmResponseTrigger(const Netmask& nm, Policy pol); + bool rmClientTrigger(const Netmask& nm, Policy& pol); + bool rmQNameTrigger(const DNSName& nm, Policy& pol); + bool rmNSTrigger(const DNSName& dn, Policy& pol); + bool rmNSIPTrigger(const Netmask& nm, Policy& pol); + bool rmResponseTrigger(const Netmask& nm, Policy& pol); bool findQNamePolicy(const DNSName& qname, DNSFilterEngine::Policy& pol) const; bool findNSPolicy(const DNSName& qname, DNSFilterEngine::Policy& pol) const; diff --git a/pdns/ixfr.cc b/pdns/ixfr.cc index 56a69c1df..c6b213753 100644 --- a/pdns/ixfr.cc +++ b/pdns/ixfr.cc @@ -27,7 +27,7 @@ #include "tsigverifier.hh" vector, vector > > processIXFRRecords(const ComboAddress& master, const DNSName& zone, - const vector& records, const std::shared_ptr masterSOA) + const vector& records, const std::shared_ptr& masterSOA) { vector, vector > > ret; diff --git a/pdns/ixfr.hh b/pdns/ixfr.hh index 970222f7e..1d9606a1e 100644 --- a/pdns/ixfr.hh +++ b/pdns/ixfr.hh @@ -29,4 +29,4 @@ vector, vector > > getIXFRDeltas(const Combo const ComboAddress* laddr=0, size_t maxReceivedBytes=0); vector, vector > > processIXFRRecords(const ComboAddress& master, const DNSName& zone, - const vector& records, const std::shared_ptr masterSOA); + const vector& records, const std::shared_ptr& masterSOA); diff --git a/pdns/sortlist.hh b/pdns/sortlist.hh index 188728b3b..cd043295a 100644 --- a/pdns/sortlist.hh +++ b/pdns/sortlist.hh @@ -31,7 +31,7 @@ struct SortListOrder struct SortListOrderCmp { - SortListOrderCmp(SortListOrder slo) : d_slo(slo) {} + SortListOrderCmp(const SortListOrder& slo) : d_slo(slo) {} bool operator()(const DNSRecord& a, const DNSRecord& b) const; const SortListOrder d_slo; }; -- 2.49.0