From 7955de9b9231f5ba7cef7ae9c3241b71e3397d0c Mon Sep 17 00:00:00 2001 From: Ruediger Pluem Date: Tue, 24 Mar 2009 11:30:47 +0000 Subject: [PATCH] * Fix a memory leak by freeing the memory consumed by the bucket. PR: 44948 Submitted by: Dan Poirier Reviewed by: rpluem git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@757741 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES | 3 +++ modules/filters/mod_substitute.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 8f22b64b9f..e16d0be1b1 100644 --- a/CHANGES +++ b/CHANGES @@ -2,6 +2,9 @@ Changes with Apache 2.3.3 + *) mod_substitute: Fix a memory leak. PR 44948 + [Dan Poirier ] + Changes with Apache 2.3.2 *) mod_mime_magic: Fix detection of compressed content. [Rainer Jung] diff --git a/modules/filters/mod_substitute.c b/modules/filters/mod_substitute.c index 98beae2c2b..07030403ab 100644 --- a/modules/filters/mod_substitute.c +++ b/modules/filters/mod_substitute.c @@ -373,7 +373,7 @@ static apr_status_t substitute_filter(ap_filter_t *f, apr_bucket_brigade *bb) */ rv = apr_bucket_read(b, &buff, &bytes, APR_BLOCK_READ); if (rv != APR_SUCCESS || bytes == 0) { - APR_BUCKET_REMOVE(b); + apr_bucket_delete(b); } else { int num = 0; -- 2.50.1