From 79287fc66bbb5b084b7b5ae4609707d680258844 Mon Sep 17 00:00:00 2001 From: Abhinav Gupta Date: Wed, 28 Sep 2011 20:29:28 +0000 Subject: [PATCH] ICU-8268 Inefficient use of new String(...) constructor. X-SVN-Rev: 30733 --- icu4j/main/classes/core/src/com/ibm/icu/text/BidiRun.java | 4 ++-- .../main/classes/core/src/com/ibm/icu/text/SpoofChecker.java | 2 +- icu4j/main/classes/core/src/com/ibm/icu/util/LocaleData.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/icu4j/main/classes/core/src/com/ibm/icu/text/BidiRun.java b/icu4j/main/classes/core/src/com/ibm/icu/text/BidiRun.java index 3bb04b73da7..1245e60c006 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/text/BidiRun.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/text/BidiRun.java @@ -1,6 +1,6 @@ /* ******************************************************************************* -* Copyright (C) 2001-2009, International Business Machines +* Copyright (C) 2001-2011, International Business Machines * Corporation and others. All Rights Reserved. ******************************************************************************* */ @@ -148,6 +148,6 @@ public class BidiRun { */ public String toString() { - return new String("BidiRun " + start + " - " + limit + " @ " + level); + return "BidiRun " + start + " - " + limit + " @ " + level; } } diff --git a/icu4j/main/classes/core/src/com/ibm/icu/text/SpoofChecker.java b/icu4j/main/classes/core/src/com/ibm/icu/text/SpoofChecker.java index 5dd6902d705..6923cb20f14 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/text/SpoofChecker.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/text/SpoofChecker.java @@ -1134,7 +1134,7 @@ public class SpoofChecker { default: assert (false); } - return new String(); + return ""; } // Populate the final binary output data array with the compiled data. diff --git a/icu4j/main/classes/core/src/com/ibm/icu/util/LocaleData.java b/icu4j/main/classes/core/src/com/ibm/icu/util/LocaleData.java index 16883766f3b..d7f9e3f2104 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/util/LocaleData.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/util/LocaleData.java @@ -268,7 +268,7 @@ public final class LocaleData { if ( noSubstitute && (stringBundle.getLoadingStatus() == ICUResourceBundle.FROM_ROOT) ) return null; - return new String (stringBundle.getString()); + return stringBundle.getString(); } /** -- 2.40.0