From 7903412fe16c367f1447527d0bcdae4c9d70617a Mon Sep 17 00:00:00 2001 From: Stefan Fritsch Date: Sun, 21 Aug 2016 14:09:00 +0000 Subject: [PATCH] ap_reclaim_child_processes() ignores its first argument note this in the docs, add comment git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1757061 13f79535-47bb-0310-9956-ffa450edef68 --- include/mpm_common.h | 3 ++- server/mpm_unix.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/mpm_common.h b/include/mpm_common.h index b366a08b12..30927ed196 100644 --- a/include/mpm_common.h +++ b/include/mpm_common.h @@ -94,7 +94,8 @@ typedef void ap_reclaim_callback_fn_t(int childnum, pid_t pid, * Make sure all child processes that have been spawned by the parent process * have died. This includes process registered as "other_children". * - * @param terminate Either 1 or 0. If 1, send the child processes SIGTERM + * @param terminate Not Implemented, value is ignored !!! + * Either 1 or 0. If 1, send the child processes SIGTERM * each time through the loop. If 0, give the process time to die * on its own before signalling it. * @param mpm_callback Callback invoked for each dead child process diff --git a/server/mpm_unix.c b/server/mpm_unix.c index db3b610702..06318fe4a2 100644 --- a/server/mpm_unix.c +++ b/server/mpm_unix.c @@ -173,6 +173,7 @@ static int reclaim_one_pid(pid_t pid, action_t action) return 0; } +/* XXX The terminate argument is ignored. Implement or remove? */ AP_DECLARE(void) ap_reclaim_child_processes(int terminate, ap_reclaim_callback_fn_t *mpm_callback) { -- 2.50.1