From 7848ae3db615beea30d1f15eb6a74f5d7a16a39a Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Wed, 11 Oct 2017 17:33:11 +0000 Subject: [PATCH] Convert the last uses of ErrorOr in COFF.h. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@315480 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Object/COFF.h | 8 ++++---- lib/Object/COFFObjectFile.cpp | 13 ++++++------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/include/llvm/Object/COFF.h b/include/llvm/Object/COFF.h index 82861240cb1..c5b500d87e2 100644 --- a/include/llvm/Object/COFF.h +++ b/include/llvm/Object/COFF.h @@ -25,7 +25,6 @@ #include "llvm/Support/ConvertUTF.h" #include "llvm/Support/Endian.h" #include "llvm/Support/ErrorHandling.h" -#include "llvm/Support/ErrorOr.h" #include #include #include @@ -1164,10 +1163,11 @@ public: ResourceSectionRef() = default; explicit ResourceSectionRef(StringRef Ref) : BBS(Ref, support::little) {} - ErrorOr> getEntryNameString(const coff_resource_dir_entry &Entry); - ErrorOr + Expected> + getEntryNameString(const coff_resource_dir_entry &Entry); + Expected getEntrySubDir(const coff_resource_dir_entry &Entry); - ErrorOr getBaseTable(); + Expected getBaseTable(); private: BinaryByteStream BBS; diff --git a/lib/Object/COFFObjectFile.cpp b/lib/Object/COFFObjectFile.cpp index 1257d1c79bd..06ac6df79ad 100644 --- a/lib/Object/COFFObjectFile.cpp +++ b/lib/Object/COFFObjectFile.cpp @@ -1648,10 +1648,9 @@ ResourceSectionRef::getDirStringAtOffset(uint32_t Offset) { return RawDirString; } -ErrorOr> +Expected> ResourceSectionRef::getEntryNameString(const coff_resource_dir_entry &Entry) { - return expectedToErrorOr( - getDirStringAtOffset(Entry.Identifier.getNameOffset())); + return getDirStringAtOffset(Entry.Identifier.getNameOffset()); } Expected @@ -1665,11 +1664,11 @@ ResourceSectionRef::getTableAtOffset(uint32_t Offset) { return *Table; } -ErrorOr +Expected ResourceSectionRef::getEntrySubDir(const coff_resource_dir_entry &Entry) { - return expectedToErrorOr(getTableAtOffset(Entry.Offset.value())); + return getTableAtOffset(Entry.Offset.value()); } -ErrorOr ResourceSectionRef::getBaseTable() { - return expectedToErrorOr(getTableAtOffset(0)); +Expected ResourceSectionRef::getBaseTable() { + return getTableAtOffset(0); } -- 2.40.0